Register dask_cudf serializers - #3832
Merged
Merged
Conversation
As `dask_cudf` simply relies on the same serialization machinery that is in `cudf` (plus whatever is implemented by `dask_cudf` objects themselves), just reuse the `cudf` serialization import to handle `dask_cudf` object serialization for simplicity.
Member
|
This seems fine to me. |
rjzamora
approved these changes
May 27, 2020
Member
|
Thanks all. Merging in |
Member
|
Oh, looks like @jakirkham needs to move out of draft mode |
jakirkham
marked this pull request as ready for review
May 27, 2020 23:54
Member
Author
|
Thanks all! Though I'm starting to second guess this change. Could use some help understanding when pickling of collections is used to better inform next steps. |
Member
|
Gah for some reason @jakirkham's last message didn't display when I hit merge. Only that it was marked as ready.
Do you want to revert it? |
Member
Author
|
No worries 🙂 I’m not aware of any downside to this change. At worst it simply doesn’t do anything. I think we can leave it in. If we determine we don’t need it, we can always come back and cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
dask_cudfsimply relies on the same serialization machinery that is incudf( plus whatever is implemented bydask_cudfobjects themselves, rapidsai/cudf#5294 ), just reuse thecudfserialization import to handledask_cudfobject serialization for simplicity.