docs: v3.1 minor cleanup (Proofs page, address encoding, constants)#148
Conversation
…ve feature-flags contract PR #3059 renamed the PlatformAddress HRPs (evo/tevo → dash/tdash) and introduced two distinct byte encodings (user-facing bech32m vs. internal GroveDB storage). PR #3522 removed the feature-flags system contract. Refresh source-line anchors against current rs-dpp line numbers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Cover the two-layer proof model (GroveDB Merkle proofs + Tenderdash consensus signatures), what can be proven, the v3.1 aggregate proof primitives (count/sum/average), and asset lock proofs. Wire it into the explanations toctree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Introduced in protocol v3 (#3491) to prevent stuck funds; v1 and v2 had no effective limit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates Dash Platform documentation to introduce comprehensive cryptographic proofs documentation, clarify Platform Address bech32m encoding specifications, remove deprecated Feature Flags system contracts, and extend sidebar navigation with new example applications and Proofs links. ChangesPlatform Documentation Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/protocol-ref/protocol-constants.md`:
- Line 258: The table row currently labeled "Platform HRP (testnet)" and showing
the value "tdash" is misleading because "tdash" is used for all non-mainnet
networks (testnet, devnet, regtest), not just testnet; update that row's
label/description to say something like "Platform HRP (non‑mainnet:
testnet/devnet/regtest)" or similar, and ensure the value "tdash" remains and
the rs-dpp link is preserved so readers understand the broader non-mainnet
scope.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 34d23a1f-4f4e-4ab9-b1c1-f7573e59ce1e
📒 Files selected for processing (7)
_templates/sidebar-main.htmldocs/explanations/platform-protocol-data-trigger.mddocs/explanations/proofs.mddocs/index.mddocs/protocol-ref/address-system.mddocs/protocol-ref/protocol-constants.mddocs/tutorials/node-setup/connect-to-a-network-dash-masternode.md
💤 Files with no reviewable changes (2)
- docs/explanations/platform-protocol-data-trigger.md
- docs/tutorials/node-setup/connect-to-a-network-dash-masternode.md
Summary
Batch of v3.1 doc updates — low-risk additions and cleanups against the v3.1-dev surface:
docs/index.mdtoctree.docs/protocol-ref/address-system.mdclarified for the new HRPs (dash/tdash) and bech32m payload structure, with a note on the two distinct byte encodings (user-facing bech32m vs. internal GroveDB storage keys). Refreshed source-line anchors against current rs-dpp line numbers.max_asset_lock_transaction_inputs(#3491) — added to the Identity Create Fees table indocs/protocol-ref/protocol-constants.md. New protocol-v3 limit (100) to prevent stuck funds.feature-flagssystem contract removed (#3522) — dropped the row fromdocs/explanations/platform-protocol-data-trigger.mdand the sample dashmate setup output in the masternode tutorial.Preview build: https://dash-docs-platform--148.org.readthedocs.build/en/148/
Summary by CodeRabbit
New Features
Documentation