Multiple issues preventing removal of external references - #50
Open
aimeos wants to merge 2 commits into
Open
Conversation
Author
|
@darylldoyle Can you have a look at the PR because without, Server-Side Request Forgery is possible |
Collaborator
|
Seems to be reasonable. I'll add some more test-cases covering the new behavior during the next few day - in case somebody else is faster, please don't hesitate... 😉 |
Owner
|
Is it possible to get some test cases added for this please? |
xerc
suggested changes
Feb 14, 2022
| $value = trim($match[1], '\'"'); | ||
|
|
||
| return preg_match('~^((https?|ftp|file):)?//~xi', $value); | ||
| return preg_match('~^((http|https|ftp|ftps|file):)?//~xi', $value); |
Contributor
There was a problem hiding this comment.
return preg_match('~^((https?|s?ftps?|file):)?//~xi', $value);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
removeRemoteReferences(true)is used, the current code fails to remove attributes with namespaces (e.g. "xlink:href"), "http" and "ftps" URLs and all URLs not wrapped inurl('...').