MicGrid: the driver fills the height; even out the cm ladder - #25
Merged
Conversation
Speaker radius 0.40 -> half the height. At 0.40 a tenth of the box was empty above and below the driver — dead space in a component whose whole job is the picture. Distance ladder in cm: 0 1 2 3 5 8 10 15 -> 0 1 2 3 5 7 10 15. The steps now grow monotonically (1 1 1 2 2 3 5); the old one swelled to 3 at the 8 and shrank back to 2, and distance is heard in ratios, so the lumpy rung read as a mistake. Inches are untouched — that ladder was already even.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small corrections found by looking at the grid inside orbit-amp's cabinet block.
The driver now fills the component's height — radius went from 0.40 of the height to half of it. At 0.40 a tenth of the box sat empty above and below the speaker, which is dead space in a component whose entire job is the picture.
The cm ladder is even.
0 1 2 3 5 8 10 15->0 1 2 3 5 7 10 15. Steps now grow monotonically (1 1 1 2 2 3 5); the old one swelled to 3 at the 8 and then shrank back to 2. Distance is heard in ratios, so that rung read as a mistake. The inch ladder is untouched — it was already even.Gate:
appkit_mic_grid_falsify_tests, 4 checks, unchanged and passing (the degenerate-size case covers the new radius maths, which now subtracts a margin and could have gone negative).