release: appkit v0.9.0 — MicGrid - #24
Merged
Merged
Conversation
MicGrid — mic placement over a drawn speaker, moved from OrbitCapture so the capture tool and the player share one picture of where a mic stands. Geometry and drawing unchanged. Namespaced into felitronics::appkit; the caption is a setter rather than a hard-coded line; new isAvailable seam so a player can show only the positions that actually have a capture behind them, which is unset and therefore inert for the capture tool. Two latent issues in the moved code, surfaced by this repo's stricter flags: an int index into a vector, and a double compared with ==.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump only; the work is in #23.
Adds
felitronics::appkit::MicGrid— mic placement over a drawn speaker, moved from OrbitCapture so both ends of the capture pipeline share one picture of where a mic stands.Source-compatible with v0.8.0: a new header, nothing existing touched.