Repository navigation
feat(rooms): add toggleable desktop chat - #144
Closed
peach-zhang wants to merge 1 commit into
Closed
peach-zhang wants to merge 1 commit into
peach-zhang wants to merge 1 commit into
Conversation
Toggle a translucent room chat with Ctrl+Alt+T and reuse session history.\nKeep chat messages out of desktop bubbles on updated peers while\npreserving Alt+T spot text and compatibility with older room clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggle a translucent room chat with Ctrl+Alt+T and reuse session history.\nKeep chat messages out of desktop bubbles on updated peers while\npreserving Alt+T spot text and compatibility with older room clients.
Fixes #
What and why
How I tested it
Ran by hand on:
Checklist
npm run typecheck,npm run test:helperandnpm testpasssrc/shared/i18n.ts, both READMEs)docs/design.mdis updated if the behaviour it describes changedAGENTS.mdin context and I read the whole diff. Tool: