fix(update): skip unmanaged local files silently, consolidate find loops#328
Open
bcdady wants to merge 2 commits into
Open
fix(update): skip unmanaged local files silently, consolidate find loops#328bcdady wants to merge 2 commits into
bcdady wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, any file present locally but absent from the remote repo produced a
Could not updatewarning — identical in appearance to a genuine failure. In practice this affects every installation: users commonly have local-only files (custom commands, skills, config) sitting alongside OAC-managed files in the same directory.Two changes:
find— three sequential find/loop blocks (md, ts, sh) replaced with a single pass.Also replaces the per-file backup/restore mechanism with a single shared temp file. Downloading to temp before overwriting the destination achieves the same safety guarantee (no partial overwrites) with less code.
Summary line before:
Summary line after:
Type of Change
Checklist
Testing
Ran
update.sh --install-dir ~/.config/opencodeagainst a global install directory containing ~130 OAC-managed files and ~16 local-only files. Local-only files were silently skipped and counted; OAC-managed files were updated as expected. No backup files left behind.