fix same candidates appearing multiple times in table - #43
Open
DongsubShim wants to merge 1 commit into
Open
Conversation
Closed
Meharab
approved these changes
Jan 30, 2021
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key changes:
Use Promise.all so all candidates are available for synchronous table update for each render() call.
Now, for two candidates, the table update would be like: (cand1 from 1st render call + cand2 from 1st) update done for 1st render … 2nd render …
Previously, multiple render() calls mixed up promises, so the table sometimes returned strange result: (cand1 from 1st + cand1 from 2nd + cand2 from 1st + cand2 from 2nd) update done for 1st and 2nd render() calls at the same time but the table showed each candidate twice.