Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/Adapter/Artax/NetscapeCookieFileJar.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,14 @@ private function parse(string $line): ?ResponseCookie
return null;
}

if ($line[0] === '#') {
// Handle httponly cookies - lines starting with #HttpOnly_ should be parsed
// See: https://curl.se/docs/http-cookies.html
$isHttpOnly = false;
if (str_starts_with($line, '#HttpOnly_')) {
$line = substr($line, 10); // Remove the '#HttpOnly_' prefix
$isHttpOnly = true;
} elseif ($line[0] === '#') {
// Regular comment line, skip it
return null;
}

Expand Down Expand Up @@ -104,6 +111,10 @@ private function parse(string $line): ?ResponseCookie
$string .= '; secure';
}

if ($isHttpOnly) {
$string .= '; httponly';
}

return ResponseCookie::fromHeader($string);
}
}
37 changes: 37 additions & 0 deletions tests/Integration/Adapter/Artax/NetscapeCookieFileJarTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,41 @@ public function testLoadCookies()
(yield $jar->get((new Request('http://127.0.0.1/'))->getUri()))[0]->getValue()
);
}

public function testLoadHttpOnlyCookies()
{
$expire = (new DateTimeImmutable())->modify('+1 day')->format('U');

$cookies = <<<EOT
# Netscape HTTP Cookie File
# This is a comment and should be ignored

#HttpOnly_.example.com TRUE / FALSE $expire session_id abc123
#HttpOnly_example.com FALSE /admin TRUE $expire admin_token xyz789
.example.com TRUE / FALSE $expire regular_cookie normal_value
EOT
;

$this->workspace()->put('httponly_cookies.txt', $cookies);
$path = $this->workspace()->path('httponly_cookies.txt');

$jar = new NetscapeCookieFileJar($path);

$allCookies = $jar->getAll();

// Should have 3 cookies total (2 httponly + 1 regular)
$this->assertCount(3, $allCookies);

// Get cookies for example.com
$exampleCookies = yield $jar->get((new Request('https://example.com/'))->getUri());

// Should include the httponly cookie
$cookieNames = array_map(fn ($cookie) => $cookie->getName(), $exampleCookies);
$this->assertContains('session_id', $cookieNames);
$this->assertContains('regular_cookie', $cookieNames);

// Verify httponly cookie value
$sessionCookie = array_filter($exampleCookies, fn ($cookie) => $cookie->getName() === 'session_id');
$this->assertEquals('abc123', reset($sessionCookie)->getValue());
}
}
Loading