Upgrade to Gradle 5 and Java 10 - #40
Open
klmcc wants to merge 2 commits into
Open
Conversation
Gradle versions before 4.3 do not work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with the work done by @vehovsky, I went through and made the changes needed to support Gradle 5. I did this while still using Java 1.8, just to keep things separate. Most of the changes were logical: upgrade gradlew related files, fix things Gradle 5 no longer supported (the closure, instances of left shift). Some of the changes, I'm not sure why they were needed: testng needed an explicit dependency, the test data in CapsuleManifestTest came out in a different (but consistent) order.
Then I looked at Java 10 support. The only problem here was that older versions of Gradle would not work. This was fixed somewhere around version 4.2.X (where X was 2 or 3). So I went into test.sh and cut off every version of Gradle before 4.3. This seemed reasonable to me, but other people may have their reasons for using older versions.
Used with Java 10, there are a number of warnings issued due to Gradle using reflection in a way that is now deprecated. I did not attempt to address those, I think that requires changes to Gradle itself.