Skip to content

Gradle 5.0 support - #39

Open
vehovsky wants to merge 1 commit into
danthegoodman:masterfrom
vehovsky:gradle5-support
Open

Gradle 5.0 support#39
vehovsky wants to merge 1 commit into
danthegoodman:masterfrom
vehovsky:gradle5-support

Conversation

@vehovsky

@vehovsky vehovsky commented Nov 7, 2018

Copy link
Copy Markdown

Simple fix for #38

@hoangtranwork

Copy link
Copy Markdown

This is a great project. However it seems like it's no longer maintained :(.

@danthegoodman

danthegoodman commented Nov 30, 2018

Copy link
Copy Markdown
Owner

I originally started this project because we needed it at my work. I've since changed positions and no longer deal with java or maven. You are correct, this is no longer maintained, but I am glad to see that it's still being used and seems to be (mostly) just working!

I just pulled in this and tried to run the tests but only got errors because grade 2 doesn't support java 10 and attempting to upgrade the tests for java 10 gave me more errors. 😖

I'm kicking myself now for not accepting #28 or #29, as that would have made it easier to deploy without my computer being in the correct state.

I'm not sure what sort of impact using different JDK versions at build time will give me, especially with compatibility for other's running different java versions.

@vehovsky @hoangtranwork If you would like to see this move forward, I could use some assistance in

  1. Updating the tests to cover gradle 5. This may be aided by the unmerged Now supports gradle 3.x #36.
  2. Documenting the required java versions for building / developing this project.

@hoangtranwork

Copy link
Copy Markdown

@danthegoodman Thank you very much for this great work. I've been using this for our Java/Kotlin backend services and it works great.

Either this is fixed or not. I will continue to use this (and keep my gradle version below 5.0 if needed). The benefit outweighs the cost.

Thank you again. Have a good day.

@dfev77

dfev77 commented Jan 4, 2019

Copy link
Copy Markdown

Gradle 4 should be enough for java 10. See new PR
However I only build it with 8, will try with 10 next days (dw too slow right now)

@gianluz

gianluz commented Jan 8, 2019

Copy link
Copy Markdown

PR is opened but looks like he is not maintaining anymore 😞 we should to fork and use the forked version

@michael-newsrx

Copy link
Copy Markdown

Where is forked version?

@hoangtranwork

Copy link
Copy Markdown

@michael what a great timing, I have just done configuring a project with gradle 5/kotlin dsl using this published fork https://plugins.gradle.org/plugin/it.gianluz.capsule

@danthegoodman

Copy link
Copy Markdown
Owner

@hoangtranwork Congrats! 😄 I've added a link to your project from my README.

@hoangtranwork

Copy link
Copy Markdown

@danthegoodman Thank you. Please note that I'm just a user of the lib, it's a @gianluz's project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants