fix(agents): remove unreachable recordUsage code - #14794
Open
zsxh1990 wants to merge 1 commit into
Open
Conversation
The recordUsage call in agents/errors.js was unreachable because: 1. `run` variable was declared but never assigned 2. `run.usage` and `run.model` would always throw TypeError 3. The catch block swallowed the error with misleading log message This was a copy/paste regression from assistants/errors.js where `run` is properly assigned via `openai.beta.threads.runs.retrieve()`. Since agents have no equivalent API, the entire block was dead code. Closes danny-avila#14792 Signed-off-by: zsxh1990 <zsxh1990@users.noreply.github.com> Signed-off-by: zsxh1990 <445655361@qq.com>
Author
|
Hi! All CI checks pass. Let me know if you'd like any changes 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
recordUsagecall inagents/errors.jswas unreachable because:runvariable was declared but never assigned (let run;)run.usageandrun.modelwould always throwTypeError: Cannot read properties of undefinedThis was a copy/paste regression from
assistants/errors.jswhererunis properly assigned viaopenai.beta.threads.runs.retrieve(). Since agents have no equivalent API, the entire block was dead code.Fix
Removed the unreachable code block and unused
recordUsageimport.Closes #14792