Modernize dependencies and Dockerfile, fix compat with modern borgmatic - #48
Open
jinnatar wants to merge 3 commits into
Open
Modernize dependencies and Dockerfile, fix compat with modern borgmatic#48jinnatar wants to merge 3 commits into
jinnatar wants to merge 3 commits into
Conversation
danihodovic
reviewed
Oct 9, 2022
|
|
||
| COPY . /app/ | ||
|
|
||
| RUN eval "$(pyenv init -)" && pyinstaller pyinstaller.spec |
Owner
There was a problem hiding this comment.
Why was this removed? I used this Dockerfile to build a pyinstaller binary and copy it from the container.
Author
There was a problem hiding this comment.
I'd recommend using for example GitHub actions instead for the build process since that can create repeatable builds directly into a GitHub release. If you prefer, I can revert the deletion of the extra Dockerfile.pyinstaller.
Owner
There was a problem hiding this comment.
Do you have sample code or can you open a PR for GH actions that generate the binary?
There was a problem hiding this comment.
Maybe just revert the Dockerfile change and merge? It'd be great to have the borgmatic cli compatibility fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows building on newer Python versions and with newer versions of dependencies, works with modern borgmatic cli structure, layer Docker image on top of
b3vis/borgmatic:latestto enable functional images for running the tool in a Dockerized environment.