ci: run pyright, and fix the config noise it surfaced

.github/workflows/ci.yml

@@ -49,6 +49,18 @@ jobs:
       - name: mypy
         run: uv run mypy src/myinvois
 
+      # Pyright is what Pylance runs in the editor, and it catches things mypy
+      # does not: it found a module-level `del` that would have raised
+      # NameError at import time if a constant tuple were ever emptied, while
+      # mypy was green. Scope comes from pyrightconfig.json (src, tests,
+      # scripts) so CI and the IDE cannot drift apart.
+      #
+      # The version is pinned through uv.lock, deliberately: Pyright ships new
+      # checks frequently, and an unpinned upgrade would fail unrelated PRs
+      # with findings nobody introduced.
+      - name: pyright
+        run: uv run pyright
+
   test:
     name: Test (Python ${{ matrix.python-version }})
     runs-on: ubuntu-latest

pyproject.toml

@@ -64,6 +64,7 @@ dev = [
     "ruff>=0.7",
     "mypy>=1.13",
     "lxml-stubs>=0.5.1",
+    "pyright[nodejs]>=1.1.400",
 ]
 
 [tool.ruff]

pyrightconfig.json

@@ -1,12 +1,14 @@
 {
-  "//": "Pyright/Pylance config. Without this, a fresh clone reports ~78 phantom",
-  "//2": "'could not be resolved' errors for httpx/pydantic/lxml/cryptography,",
-  "//3": "because Pyright does not find .venv on its own. Checked in so the IDE",
-  "//4": "and the command line agree for everyone.",
+  // Pyright/Pylance config. Without venvPath/venv, a fresh clone reports ~78
+  // phantom "could not be resolved" errors for httpx, pydantic, lxml and
+  // cryptography, because Pyright does not find .venv on its own. Checked in
+  // so the IDE, the command line and CI all agree.
   "venvPath": ".",
   "venv": ".venv",
   "include": ["src", "tests", "scripts"],
-  "exclude": ["**/__pycache__", ".venv", "dist"],
+  // Specifying `exclude` replaces Pyright's defaults, so the usual ones are
+  // repeated here rather than silently dropped.
+  "exclude": ["**/node_modules", "**/.*", "**/__pycache__", ".venv", "dist"],
   "pythonVersion": "3.11",
   "typeCheckingMode": "standard",
   "reportMissingTypeStubs": false