Skip to content

Intradaily Variability - #19

Open
matiasvinicius wants to merge 2 commits into
mainfrom
npcra_iv
Open

Intradaily Variability#19
matiasvinicius wants to merge 2 commits into
mainfrom
npcra_iv

Conversation

@matiasvinicius

@matiasvinicius matiasvinicius commented May 9, 2022

Copy link
Copy Markdown
Collaborator

Related to issue #3

Comment thread R/npcra_iv.R Outdated
x <- data[[col]]
timestamp <- data[[tsibble::index(data)]]

if (minutes_interval <= 0 | minutes_interval > 1440) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utilize a forma "longa" dos operadores lógicos para condicionantes não vetoriais:

if (minutes_interval <= 0 || minutes_interval > 1440) {

https://stat.ethz.ch/R-manual/R-devel/library/base/html/Logic.html

Comment thread R/npcra_iv.R Outdated
"\nminutes_interval = ", minutes_interval)
}

if(minutes_interval == 1) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajuste o código de acordo com o guia de estilo do tidyverse.

https://style.tidyverse.org/syntax.html#if-statements

Comment thread R/npcra_iv.R Outdated
#' no way to define a standard for the data and, therefore, will have
#' a high variability.
#'
#'From the IV stipulated by Witting et al, other estimates based on the IV were

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicionar espaço entre #' e texto.

@danielvartan danielvartan self-assigned this May 31, 2022
@danielvartan danielvartan added the enhancement New feature or request label May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants