Phase 4.4: bundled interface typeface - #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30
Bundles iA Writer Quattro as the Interface typeface for non-editor chrome (Document selector, feedback, search).
Deviation from spec
The spec said static Regular+Bold; both static
Sfaces ship OS/2usWeightClass608 → fontdb normalizes to weight 400 for both, so NORMAL and BOLD queries resolve to the same face and interface bold would not render. Verified empirically. Bundle instead the variable fontiAWriterQuattroV.ttf(familyiA Writer Quattro V,wght400–700): shaping test proves bold ≠ normal metrics. OFL license bundled atassets/fonts/iA-Writer-Quattro-LICENSE.md.Changes
src/fonts.rs:INTERFACE_TYPEFACE_FAMILY,register_bundled_interface_typeface()(include_bytes, non-fatal), 2 testssrc/main.rs: register at startup (normal + smoke paths)src/editor.rs+src/shell.rs:interface_labelhelper applies family to selector/feedback/search surfacesassets/fonts/:iAWriterQuattroV.ttf+ licenseNote
Branch carries #29 FontDelivery commits (d2994b2, 968ff7c) ahead of main; they land with this PR (merge commit keeps history, as with #28 via #34).
Verification