fix(CrossVendorAudit): raise codex timeout to 600s and pin reasoning_effort=medium#1383
Open
ryan-baum wants to merge 1 commit into
Open
fix(CrossVendorAudit): raise codex timeout to 600s and pin reasoning_effort=medium#1383ryan-baum wants to merge 1 commit into
ryan-baum wants to merge 1 commit into
Conversation
…effort=medium The cross-vendor audit (Cato, Rule 2a) silently returns verdict:skipped on real ISAs: codex exec --model gpt-5.4 is a reasoning model needing ~3min on a real bundle, but CODEX_TIMEOUT_MS caps at 120s, so SIGTERM fires before a verdict returns. Also pin model_reasoning_effort=medium so latency is bounded by an explicit known-good tier rather than an inherited config default (high/xhigh can exceed even 600s). Narrowly scoped; independent of danielmiessler#1346.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. Cato's cross-vendor audit (Rule 2a, E4/E5) silently returns
verdict: "skipped"on real ISAs.CrossVendorAudit.tscaps the codex call atCODEX_TIMEOUT_MS = 120_000(2 min), butcodex exec --model gpt-5.4is a reasoning model: on a real ISA + artifact bundle it routinely needs ~3 min. The 120s cap fires first →SIGTERM→[TIMEOUT after 120s]→ the audit is skipped before GPT-5.4 ever returns a verdict. The cross-vendor gate looks like it ran but produced nothing.Two compounding factors:
reasoning_effortis pinned, so the call inherits~/.codex/config.toml's default. If that default ishigh/xhigh, the call blows past even a generous timeout. Empirically,mediumreturns a full audit in ~3 min;xhighexceeds 600s on a real bundle.Fix. Raise the in-process cap to 600s and pin
model_reasoning_effort=mediumso latency is bounded by an explicit, known-good effort tier rather than an inherited config default.Why
mediumand not just a bigger timeout. A bigger timeout alone doesn't help if the inherited effort default isxhigh(it can exceed 600s on a real ISA). Pinningmediummakes the audit's latency predictable and keeps it inside the cap. This is the load-bearing half of the fix.Scope / non-overlap. Narrowly scoped to the timeout constant, the spawn args, and the timeout message string. Does not touch the
--skip-git-repo-check/OPENAI_API_KEYenv-inheritance work already in flight in #1346 — these are independent and should merge cleanly alongside it.Testing.
bun CrossVendorAudit.ts --doctorstill passes; a full E4/E5 audit that previously skipped at 120s now returns a parsed verdict in ~3 min.