Skip to content

Fix: Exit gracefully on already optimised files. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cadesalaberry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Exit gracefully on already optimised files. #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions qtfaststart/processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,9 @@ def process(infilename, outfilename, limit=float('inf'), to_end=False,

if offset == 0:
# No free atoms to process and moov is correct, we are done!
msg = "This file appears to already be setup!"
msg = "This file appears to be already optimised for streaming. Nothing to do."
log.error(msg)

@cbenhagen cbenhagen Mar 22, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Info log level should be enough in this case.

Suggested change
log.error(msg)
log.info(msg)

raise FastStartSetupError(msg)
return

# Check for compressed moov atom
is_compressed = _moov_is_compressed(datastream, moov_atom)
Expand Down