Repository navigation
Working CI pipeline - #1
Merged
Merged
Conversation
- Add GitHub Actions CI workflow with lint job (pre-commit) and test job - Lint job runs black and isort checks before tests execute - Test matrix: Python 3.9-3.13 on Ubuntu, macOS, Windows - Add .pre-commit-config.yaml with black and isort hooks - Add black/isort configuration to pyproject.toml - Format entire codebase with black and isort - Add CI, Python version, black, isort badges to README
- Remove branch filter on push so CI runs on all branches, not just main - Add separate Lint and Tests badges to README - Tests badge uses shields.io for proper rendering
setuptools.backends._legacy is not available in older setuptools versions shipped with Python 3.9, causing pip install -e to fail on CI.
pyreadr does not provide wheels for Python 3.9, causing CI failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working CI pipeline
This pull request introduces several improvements to the codebase, focusing on code style consistency, enhanced CI/CD workflows, and minor refactoring for clarity and maintainability. The main changes include adding pre-commit linting, updating the CI workflow, improving documentation, and refactoring code for readability.
Continuous Integration and Linting Improvements:
.github/workflows/tests.ymlto.github/workflows/ci.yml, added a dedicatedlintjob using pre-commit withblackandisort, and made linting a prerequisite for running tests. Also removed Python 3.9 from the test matrix..pre-commit-config.yamlfile to configureblackandisortfor code formatting and import sorting.Documentation and Badges:
README.mdto include CI, test, Python version, and code style badges, improving project visibility and documentation.Code Style and Refactoring:
pybastion/__init__.py,pybastion/_obs_error.py, andpybastion/_evol_params.py, to adhere to linting standards. [1] [2] [3]pybastion/_evol_params.pyandpybastion/_mcmc.py. [1] [2] [3] [4] [5]pybastion/_mcmc.pyfor consistency and style compliance.These changes collectively enhance code quality, enforce consistent style, and improve the development workflow.