Make download URL relative from subdirectory ('./') vs relative from root ('/') - #45
Open
rbruels wants to merge 1 commit into
Open
Make download URL relative from subdirectory ('./') vs relative from root ('/')#45rbruels wants to merge 1 commit into
rbruels wants to merge 1 commit into
Conversation
|
Thanks this works well for me. |
Author
|
@daniel-j Just noticing I still have this open. Do you want to integrate this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty straightforward change — this changes the download link to be relative to the current directory, rather than relative to the root.
I host the site at a subdirectory which works great except that the download link gets set to
/[file]— i.e. pointed to a file at the root of the site — and all download links 404. This resolves that issue.For sites operating at the root (i.e. send.djazz.se) this will still point the download to the correct location.
(Love this app and use the hell out of it @daniel-j so thank you!)