Run CI on Node 22 - #1526
Open
Socialpranker wants to merge 1 commit into
Open
Conversation
The "Make a small babel app" step builds a create-react-app, whose template depends on @testing-library/jest-dom at ^6.9.1. That range now resolves to 6.10.0, which requires Node >=22, so on Node 20 yarn refuses to install it: error @testing-library/jest-dom@6.10.0: The engine "node" is incompatible with this module. Expected version ">=22". Got "20.20.2" and the step fails before Danger runs. Only the CI workflow changes here. release.yml doesn't build a CRA, so it isn't affected, and the package's own engines field still allows >=18.
Contributor
Author
|
CI is green on this one, so the local repro caveat above is moot now. The runner picked up That's the step that had been failing, so this should unblock #1524, #1525 and anything else opened against main. |
Member
|
👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI has been red on every PR for a while now, and it isn't the PRs. The "Make a small babel app" step runs
create-react-app, whose template depends on@testing-library/jest-domat^6.9.1. That range now resolves to 6.10.0, which declaresengines.node: ">=22", and the workflow pins Node 20, so yarn bails out before Danger ever runs:The same failure shows up on #1524 (22 Jul) and on my #1525, which touch unrelated things, so it's the workflow rather than either change.
This bumps
node-versioninCI.ymlfrom 20 to 22, the minimum that satisfies the new constraint.I left the rest alone deliberately.
release.ymlalso pins Node 20, but it never builds a CRA so it isn't affected, and I'd rather not touch the publishing path without a reason.enginesinpackage.jsonstill says>=18, which is about what Danger supports for its users and is a separate question from what CI runs on.One caveat on verification: I couldn't reproduce the failure locally, because a local
create-react-apprun resolved jest-dom to 6.9.1 rather than 6.10.0, and 6.9.1 still allows Node 14. So my evidence is the CI logs plus the publishedenginesfield on 6.10.0, not a local repro. The run on this PR is the real test.#trivial
Written with Claude Code (Claude Opus 5); I reviewed and tested everything before submitting.