Repository navigation
Stream validation in parallel - #1956
Draft
CodyCBakerPhD wants to merge 9 commits into
Draft
CodyCBakerPhD wants to merge 9 commits into
CodyCBakerPhD wants to merge 9 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## claude/datalad-fuse-readable #1956 +/- ##
================================================================
+ Coverage 91.10% 91.32% +0.22%
================================================================
Files 96 96
Lines 14648 14956 +308
================================================================
+ Hits 13345 13659 +314
+ Misses 1303 1297 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
CodyCBakerPhD
added this pull request to stack #1959
October 12, 2026 21:30
CodyCBakerPhD
force-pushed
the
claude/validate-stream-via-datalad-fuse
branch
from
October 12, 2026 21:32
0be1c28 to
106f661
Compare
Contributor
Author
|
Note: test on https://dandiarchive.org/dandiset/001769 (BIDS with nifti's; @yarikoptic had concern about BIDS validator fetching content) |
CodyCBakerPhD
force-pushed
the
claude/validate-stream-via-datalad-fuse
branch
from
October 15, 2026 17:58
a65f6ee to
336ec0b
Compare
CodyCBakerPhD
removed this pull request from stack #1959
October 15, 2026 18:34
CodyCBakerPhD
added this pull request to stack #1965
October 15, 2026 19:28
Add a `stream` policy to `--missing-file-content`: the content of annexed files that is not present locally (as in a DataLad clone of a Dandiset) is streamed with datalad-fuse's adapter, so that pynwb and nwbinspector run on it without it being downloaded. pynwb validation results are cached under the files' git-annex keys. This is the validation integration of #1933, on top of the datalad-fuse readable rather than a git-only reader of the git-annex branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
This reverts commit d18843d. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
The results of inspecting an NWB file are cached in the validation cache, under the file (by stat() for a local file, or by its git-annex key for streamed content; see `annex_fingerprint`) and the version of nwbinspector, so that validating again does not inspect (and for streamed content, download) unchanged files again. A failure to read streamed content, which might be transient, is not cached. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Validating a streamed file mostly waits for its content to be downloaded, one request at a time (h5py serializes all reading of HDF5 files in a process), so validate NWB files (other than those of BIDS datasets, which are validated together) in a pool of processes, started with "spawn" since this process may run threads (e.g., fsspec's). The results are yielded in the same order as without the pool; the workers' log records are handled by the handlers of the main process. Streamed content is set up again in the worker, as its source cannot be sent to another process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
Validating streamed content can take a long time per file, during which
nothing was shown. Find all the files to validate first, log their
number, and log for each file when it is done ("[3/120] sub-01/...nwb:
2 issues"), including for the files validated in parallel with --jobs,
as they finish.
The `dataset_description.json` files of BIDS datasets, to which the
assets found refer only weakly, are kept alive while their assets are
validated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…fuse Follow the base branch, which streams annexed content with remfile from the URLs git-annex knows, without datalad-fuse: `--missing-file-content=stream` now requires remfile (`dandi[streaming]`) and git-annex, and never runs a `git annex` command in a clone in which git-annex is not initialized. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
…datalad]` Follow dandi.support.annex_stream streaming with datalad-fuse's adapter and its remfile backend: the stream policy now requires datalad-fuse with remfile (`pip install 'dandi[datalad]'`), checked with `can_stream()`, and the documentation says how the content is read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr
CodyCBakerPhD
force-pushed
the
claude/validate-stream-via-datalad-fuse
branch
from
October 16, 2026 03:23
ea4dbbf to
63ee181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1955.
Stream
dandi validatethroughdatalad-fuseadapters (not FUSE mounts).Try this out with
and then
con-duct ls -F message wall_clock_time peak_rss average_pcpu exit_codeshould give something likeand then
dandi validate --load 000006-cold.jsonl --summaryshould give🤖 AI text below here 🤖
Details
Changes
streampolicy for--missing-file-content:AnnexedReadableFile, and pynwb and nwbinspector run on the streamed content.DANDI.FILE_CONTENT_STREAMED, naming the first URL git-annex reported for its content.DANDI.FILE_CONTENT_MISSINGerror.git annexcommand runs, so the clone isn't modified, and every file is reported as missing.dandi validateto operate on Datalad datasets through streaming #1933:LocalFileAsset.content_sourcelets an asset read its content from aReadable.pynwb_utils.validate(..., readable=...)validates content from aReadable.only-non-data.annex_fingerprintfrom Stream missing annexed content with remfile, cached by annex key #1955.-J/--jobs N: NWB files outside BIDS datasets are validated inNprocesses. Results are yielded in the same order as with 1 (the default), and the workers' log messages are forwarded to the main process.[12/53] sub-01/sub-01_ses-1.nwb: 3 issues.pip install "dandi[datalad]") and git-annex, and raises an error if either is missing. Until datalad-fuse releases its remfile backend, the extra pins the head commit of ENH: add remfile backend with pluggable backend architecture datalad/datalad-fuse#131 (see Stream missing annexed content with remfile, cached by annex key #1955).validatedocs explains the policy, usingdatalad clone.dandi validateto operate on Datalad datasets through streaming #1933 are rewritten to use a real git-annex repository and the local HTTP range server from Stream missing annexed content with remfile, cached by annex key #1955. They cover:--jobsand progress output.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qn5WBSiQgoZoL4fytF6nEr