Fix: do not drop parallel row bounds when merging into an equality - #51
Merged
dance858 merged 2 commits intoAug 1, 2026
Merged
Conversation
dance858
approved these changes
Aug 1, 2026
Owner
|
Awesome, very nice catch! Thanks for this contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50.
When an equality row becomes the remaining row of a bin, the sides accumulated from the rows processed before it were dropped without being checked. Those rows are deleted at the end of the merge, so a bound they carried could vanish and leave the reduced problem weaker than the original.
The fix compares the equality against those sides before the swap discards them. That comparison is also what makes discarding them sound: if the equality lies inside them, it is the tighter constraint, and they are redundant; and if it lies outside, the bin is infeasible.
test_17_parallel_rowsis the case from the issue. It fails on the current main in both Debug and Release.