Skip to content

Fix issue where users sometimes cannot see their own posts#3785

Merged
danieldaquino merged 1 commit into
damus-io:masterfrom
danieldaquino:daniel-ios-2339-users-sometimes-cannot-see-their-own-posts
May 26, 2026
Merged

Fix issue where users sometimes cannot see their own posts#3785
danieldaquino merged 1 commit into
damus-io:masterfrom
danieldaquino:daniel-ios-2339-users-sometimes-cannot-see-their-own-posts

Conversation

@danieldaquino

@danieldaquino danieldaquino commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

Sometimes users would not see their own posts on the home timeline after posting.

The issue was that there was a filter being applied to the home timeline that would hide their own posts if they did not follow themselves (which I confirmed was the case for the users who recently reported the issue)

Checklist

Warning

Please file an issue or create a ticket for the work in this PR, then link it here.
We use issues and tickets to triage and prioritize work, so PRs without a linked issue/ticket may be delayed.

Standard PR Checklist

  • I have read (or I am familiar with) the Contribution Guidelines
  • I have tested the changes in this PR
  • I have profiled the changes to ensure there are no performance regressions, or I do not need to profile the changes.
  • I have filed or linked an existing issue/ticket related to this change.
  • My PR is either small, or I have split it into smaller logical commits that are easier to review
  • I have added the signoff line to all my commits. See Signing off your work
  • I have added appropriate changelog entries for the changes in this PR. See Adding changelog entries
  • I have added appropriate Closes: or Fixes: tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patches

Test report

Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.

Device: iPhone simulator

iOS: 26

Damus: c035cee

Steps:

  1. Unfollow self
  2. Post something
  3. Check if it appears on the home timeline

Results:

  • PASS

Note: Also verified that problem was reproducible before the change using the same procedure

Other notes

[Please provide any other information that you think is relevant to this PR.]

Summary by CodeRabbit

  • Bug Fixes
    • Updated the contact filter to now include the user's own posts alongside posts from contacts, improving content visibility.

Review Change Stack

… themselves

Closes: damus-io#3675
Changelog-Fixed: Fixed an issue where posts would not appear on the user's own timeline if they did not follow themselves
Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: be48a5b6-f9c2-43be-9e95-439540745cf7

📥 Commits

Reviewing files that changed from the base of the PR and between 06e4fa2 and c035cee.

📒 Files selected for processing (1)
  • damus/Features/Follows/Models/Contacts.swift

📝 Walkthrough

Walkthrough

The friend_filter in the Contacts model is updated to include events authored by the user in addition to events from friend accounts. The filter predicate changes from is_friend(ev.pubkey) to is_friend_or_self(ev.pubkey), with documentation clarifying this behavior.

Changes

Friend Filter Update

Layer / File(s) Summary
Include self in friend filter
damus/Features/Follows/Models/Contacts.swift
The friend_filter predicate is updated from is_friend(ev.pubkey) to is_friend_or_self(ev.pubkey) to include the user's own events alongside friend account events, with documentation added.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A filter grows with gentle care,
Self and friends now both are there,
One small change, a logic shift—
User events get added as a gift! 🎁

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change—fixing the issue where users cannot see their own posts in the home timeline.
Description check ✅ Passed The PR description is comprehensive, following the template with a clear summary, completed standard checklist, detailed test report, and proper documentation of the issue and fix.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danieldaquino
danieldaquino merged commit bc3125d into damus-io:master May 26, 2026
1 of 2 checks passed
@danieldaquino
danieldaquino deleted the daniel-ios-2339-users-sometimes-cannot-see-their-own-posts branch May 26, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant