Fix issue where users sometimes cannot see their own posts#3785
Conversation
… themselves Closes: damus-io#3675 Changelog-Fixed: Fixed an issue where posts would not appear on the user's own timeline if they did not follow themselves Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesFriend Filter Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Sometimes users would not see their own posts on the home timeline after posting.
The issue was that there was a filter being applied to the home timeline that would hide their own posts if they did not follow themselves (which I confirmed was the case for the users who recently reported the issue)
Checklist
Warning
Please file an issue or create a ticket for the work in this PR, then link it here.
We use issues and tickets to triage and prioritize work, so PRs without a linked issue/ticket may be delayed.
Standard PR Checklist
Closes:orFixes:tags in the commit messages wherever applicable, or made sure those are not needed. See Submitting patchesTest report
Please provide a test report for the changes in this PR. You can use the template below, but feel free to modify it as needed.
Device: iPhone simulator
iOS: 26
Damus: c035cee
Steps:
Results:
Note: Also verified that problem was reproducible before the change using the same procedure
Other notes
[Please provide any other information that you think is relevant to this PR.]
Summary by CodeRabbit