fix(T2194): add missing values mapping for RETURN_HOME command - #577
Closed
o8uzhan wants to merge 1 commit into
Closed
fix(T2194): add missing values mapping for RETURN_HOME command#577o8uzhan wants to merge 1 commit into
o8uzhan wants to merge 1 commit into
Conversation
RETURN_HOME command for L35 Hybrid (T2194) had no 'values' mapping, causing getRoboVacCommandValue() to fall back to sending the raw string 'return' to a DPS code (101) that the device expects as a boolean. This caused the vacuum to start cleaning instead of returning to dock when 'Return to Dock' was pressed. Confirmed via debug logs on real hardware: DPS 101 is reported as a bool in every status update from the device. Added a regression test verifying getRoboVacCommandValue() maps 'return' to True for this model.
o8uzhan
force-pushed
the
fix/l35-hybrid-return-home-dps
branch
from
July 25, 2026 11:42
94c431a to
76e75b9
Compare
damacus
approved these changes
Jul 27, 2026
Owner
|
I'm going to roll this up into #578, thanks for pointing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
L35 Hybrid (T2194) vacuums don't return to dock when
vacuum.return_to_baseis called in Home Assistant — instead they start cleaning.Root cause
RETURN_HOMEcommand inT2194.pyhad novaluesmapping:getRoboVacCommandValue()falls back to sending the raw string"return"when no mapping exists, but DPS code 101 on this device is a boolean field — confirmed via debug logs where every status update reports'101': False. Sending a string instead ofTruecauses the vacuum firmware to ignore the command and it starts a cleaning cycle instead.Fix
Added the missing values mapping:
Testing
test_t2194_return_home_valueregression test — passes.{"101": "return"}and the vacuum started cleaning. After the fix, it correctly returns to dock.