Skip to content

fix(T2194): add missing values mapping for RETURN_HOME command - #577

Closed
o8uzhan wants to merge 1 commit into
damacus:mainfrom
o8uzhan:fix/l35-hybrid-return-home-dps
Closed

fix(T2194): add missing values mapping for RETURN_HOME command#577
o8uzhan wants to merge 1 commit into
damacus:mainfrom
o8uzhan:fix/l35-hybrid-return-home-dps

Conversation

@o8uzhan

@o8uzhan o8uzhan commented Jul 25, 2026

Copy link
Copy Markdown

Problem

L35 Hybrid (T2194) vacuums don't return to dock when vacuum.return_to_base is called in Home Assistant — instead they start cleaning.

Root cause

RETURN_HOME command in T2194.py had no values mapping:

RobovacCommand.RETURN_HOME: {
    "code": 101,
},

getRoboVacCommandValue() falls back to sending the raw string "return" when no mapping exists, but DPS code 101 on this device is a boolean field — confirmed via debug logs where every status update reports '101': False. Sending a string instead of True causes the vacuum firmware to ignore the command and it starts a cleaning cycle instead.

Fix

Added the missing values mapping:

RobovacCommand.RETURN_HOME: {
    "code": 101,
    "values": {"return": True},
},

Testing

  • Added test_t2194_return_home_value regression test — passes.
  • Confirmed on real L35 Hybrid hardware: before the fix, pressing 'Return to Dock' sent {"101": "return"} and the vacuum started cleaning. After the fix, it correctly returns to dock.
  • Full test suite for this model (7 tests) passes.

RETURN_HOME command for L35 Hybrid (T2194) had no 'values' mapping,
causing getRoboVacCommandValue() to fall back to sending the raw
string 'return' to a DPS code (101) that the device expects as a
boolean. This caused the vacuum to start cleaning instead of
returning to dock when 'Return to Dock' was pressed.

Confirmed via debug logs on real hardware: DPS 101 is reported as
a bool in every status update from the device.

Added a regression test verifying getRoboVacCommandValue() maps
'return' to True for this model.
@o8uzhan
o8uzhan force-pushed the fix/l35-hybrid-return-home-dps branch from 94c431a to 76e75b9 Compare July 25, 2026 11:42
@damacus

damacus commented Jul 28, 2026

Copy link
Copy Markdown
Owner

I'm going to roll this up into #578, thanks for pointing this out.

@damacus damacus closed this Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants