fix: Docker build improvements β disable debug symbols, add ccache, add .dockerignore - #725
Open
dyiapanis wants to merge 1 commit into
Open
fix: Docker build improvements β disable debug symbols, add ccache, add .dockerignore#725dyiapanis wants to merge 1 commit into
dyiapanis wants to merge 1 commit into
Conversation
β¦dd .dockerignore (daijro#698)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #698
Description
Three Docker build fixes:
Add
--disable-debug-symbolstoassets/linux.mozconfigβ Distribution builds don't ship symbols anyway. Debug info inflates memory usage at the link stage, causing OOM kills on arm64 builds (thegkrustfat-LTO staticlib +libxullink peaks past available RAM). This keeps the link under the RAM ceiling and shrinks the binary.Add
ccacheto Dockerfile apt-get install βassets/base.mozconfigalready has a conditionalif command -v ccachecheck, but the Dockerfile never installs ccache, so every Docker build runs cold. Adding ccache to the package list makes the conditional actually trigger, enabling incremental build caching.Add
.dockerignoreβ Without it,COPY . /appships.git,dist/,node_modules/, and built artifacts into the build context. This trims the context substantially and preventspatch.py'sgit clean -fdxfrom walking up to the host git work tree created byCOPY . /app.Type of Change
Testing
Checklist