chore: verificar pre-commit y limpiar EOF de .gitignore - #5
Merged
Conversation
…mpio) Verificación del .pre-commit-config.yaml recién añadido: `pre-commit run --all-files` reescribía .gitignore (línea en blanco final sobrante). Corregido, así el primer run de un contribuidor es no-op en vez de reescribir archivos. Los hooks (ruff/ruff-format/shellcheck/eof/whitespace) ahora pasan todos limpios. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cierre del lado local del proceso: verifiqué que
.pre-commit-config.yaml(añadido en #4) realmente funciona corriendopre-commit run --all-files.Resultado: el hook
end-of-file-fixerreescribía.gitignore(una línea en blanco final sobrante de una edición previa). Esto significaba que el primerpre-commit runde cualquier contribuidor modificaría archivos — justo lo que no debe pasar con un config que se entrega para instalar..gitignore.pre-commit run --all-filesahora pasa todos los hooks limpio (ruff, ruff-format, shellcheck, eof, trailing-whitespace, merge-conflict, large-files).Segundo PR que pasa por el CI estricto.
🤖 Generated with Claude Code