Skip to content

fix(axios): respect form data boundary from Request constructor - #44

Merged
orionmiz merged 3 commits into
mainfrom
axios-clone-request
Sep 9, 2025
Merged

fix(axios): respect form data boundary from Request constructor#44
orionmiz merged 3 commits into
mainfrom
axios-clone-request

Conversation

@orionmiz

@orionmiz orionmiz commented Sep 8, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@changeset-bot

changeset-bot Bot commented Sep 8, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7aba9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
plantae Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Sep 8, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Form-data requests now correctly defer Content-Type handling to preserve the multipart boundary, improving compatibility with servers.
    • Increases reliability of uploads and form submissions, including after automatic retries.
  • Tests

    • Added coverage to ensure form-data requests succeed when retried after transient errors.
  • Chores

    • Added a patch-level changeset entry documenting the fix.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb7789 and c7aba9f.

📒 Files selected for processing (3)
  • .changeset/short-bulldogs-lick.md (1 hunks)
  • packages/plantae/src/axios/createAxiosInterceptors.spec.ts (1 hunks)
  • packages/plantae/src/axios/createAxiosInterceptors.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch axios-clone-request

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@orionmiz orionmiz changed the title fix(axios): clone request on middleware fix(axios): let Request constructor set boundary into content type header Sep 9, 2025
@orionmiz orionmiz changed the title fix(axios): let Request constructor set boundary into content type header fix(axios): make Request constructor set form data boundary into content type header Sep 9, 2025
@orionmiz orionmiz changed the title fix(axios): make Request constructor set form data boundary into content type header fix(axios): respect form data boundary from Request constructor Sep 9, 2025
@orionmiz
orionmiz marked this pull request as ready for review September 9, 2025 16:33
@orionmiz
orionmiz enabled auto-merge (squash) September 9, 2025 16:35
@orionmiz
orionmiz merged commit 35bfb6c into main Sep 9, 2025
4 of 5 checks passed
@orionmiz
orionmiz deleted the axios-clone-request branch September 9, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant