test: add coverage for _haversine and _check_input_parameters - #12
Merged
Conversation
Salvaged from #4, which was written against the pre-restructure dclimate_zarr_client package and is otherwise obsolete. These two utilities still exist in geotemporal_data.py and were previously untested.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new test module for geotemporal utilities, covering the ChangesGeotemporal Utility Tests
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for two previously-untested geotemporal utilities in
geotemporal_data.py:_haversine— single-point and vectorized (array) distance calculations_check_input_parameters— invalid time-period and aggregation-method validationThese tests are salvaged from #4, which was written against the pre-restructure
dclimate_zarr_clientpackage. The bulk of that PR targeted the old IPNS/STAC catalog traversal code that has since been removed/rewritten, but these two utilities still exist and were not covered by the current suite.Summary by CodeRabbit