fix: show ⌥ and ⌃ symbols for Alt/Option and Ctrl on macOS - #527
fix: show ⌥ and ⌃ symbols for Alt/Option and Ctrl on macOS#527yuzu-octopus wants to merge 1 commit into
Conversation
Use macOS keyboard symbols in help bar instead of M- and ^ notation when built on Apple platforms, matching established __APPLE__ guard pattern in src/uikeyconfig.cpp.
|
Hi @yuzu-octopus - thanks for contributing. I will try find some time to review and feedback soon. |
|
hi @d99kris just curious how is this? I just wanna know if this will be merged thx! |
|
Hi @yuzu-octopus - thanks for checking in, I haven't found time to think about this properly yet. Just to adjust expectations - in this project the recommended workflow is to first submit a feature request, and once aligned on with maintainers, a PR may be submitted that implements it. So for this change we are still at "specification" stage, rather than "code review" stage. Anyway, my main concern about this change is that users may be using a non-macOS system (say Linux) to SSH into a macOS system and running nchat there - and the Linux machine might not have these special Apple characters installed. I myself use nchat like this sometimes. An alternative solution could be to simply make these symbols user-configurable, with suggested config values for macOS (or other OS) users. |
2 participants
Shows ⌥ and ⌃ in help bar instead of M- and ^ on macOS.
Follows the existing APPLE pattern in uikeyconfig.cpp.