Skip to content

fix(speech): pin the voice models to a revision instead of someone else's HEAD #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d4vid87 merged 1 commit into from
Sep 3, 2026
Merged

fix(speech): pin the voice models to a revision instead of someone else's HEAD #294

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions crates/hookecho/src/speech.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,18 @@ pub const VOICES: &[&str] = &[
///
/// `None` for an id that is not shaped like a Piper id, which is how a hand-typed value is
/// refused before it becomes a URL.
/// The `rhasspy/piper-voices` revision voices are fetched from.
///
/// A commit, not `main`. These files are ONNX models this app downloads and then runs, and
/// `resolve/main` means whatever is at the head of someone else's repository at the moment the
/// button is pressed — a different model tomorrow, and a different one for two users on the same
/// build. Pinning makes the download reproducible and makes a change to it a change to this file.
///
/// Bumping it is deliberate: pick a commit from
/// `https://huggingface.co/api/models/rhasspy/piper-voices` and paste its `sha` here.
#[cfg(not(target_arch = "wasm32"))]
const VOICES_REVISION: &str = "39ab474be869e9181350af6a65e4953eef67aaa0";

#[cfg(not(target_arch = "wasm32"))]
pub fn voice_url(id: &str) -> Option<String> {
let mut parts = id.split('-');
Expand All @@ -91,7 +103,7 @@ pub fn voice_url(id: &str) -> Option<String> {
}
let base = lang.split('_').next()?;
Some(format!(
"https://huggingface.co/rhasspy/piper-voices/resolve/main/{base}/{lang}/{name}/{quality}/{id}.onnx"
"https://huggingface.co/rhasspy/piper-voices/resolve/{VOICES_REVISION}/{base}/{lang}/{name}/{quality}/{id}.onnx"
))
}

Expand Down Expand Up @@ -307,12 +319,17 @@ mod tests {
#[test]
fn a_voice_id_derives_its_own_download_url() {
assert_eq!(
voice_url("en_US-lessac-medium").as_deref(),
Some("https://huggingface.co/rhasspy/piper-voices/resolve/main/en/en_US/lessac/medium/en_US-lessac-medium.onnx")
voice_url("en_US-lessac-medium"),
Some(format!("https://huggingface.co/rhasspy/piper-voices/resolve/{VOICES_REVISION}/en/en_US/lessac/medium/en_US-lessac-medium.onnx"))
);
assert_eq!(
voice_url("pt_BR-faber-medium").as_deref(),
Some("https://huggingface.co/rhasspy/piper-voices/resolve/main/pt/pt_BR/faber/medium/pt_BR-faber-medium.onnx")
voice_url("pt_BR-faber-medium"),
Some(format!("https://huggingface.co/rhasspy/piper-voices/resolve/{VOICES_REVISION}/pt/pt_BR/faber/medium/pt_BR-faber-medium.onnx"))
);
// A commit, never a branch: `resolve/main` is whatever someone else's head happens to be.
assert!(
VOICES_REVISION.len() == 40 && VOICES_REVISION.chars().all(|c| c.is_ascii_hexdigit()),
"VOICES_REVISION must be a full commit sha, got {VOICES_REVISION}"
);
// Underscores are part of names and qualities both, and must survive.
assert!(voice_url("en_US-hfc_female-medium")
Expand Down
Loading