Repository navigation
Implemented DiceNotation enhancements - #1
Merged
Merged
Conversation
Turned on warnings as errors. Fixed warnings in test project.
Updated package references to latest versions.
…rs, and trackers (optionally). Provided a notation options builder to configure the services. Added unit tests for the DI methods.
Added `DiceResult` breakdown helpers. Updated DiceCli to show more verbose dice result output.
… now accept a seed. Added the DieRollerFactory class and builder options for seeded rollers. Added unit tests. Updated documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddDiceNotation()service-collection extensions to registerIDice, configuration, die roller, and optional roll tracker cleanly through dependency injection.DiceNotationOptionsBuilderfluent API for configuring die sides, bounded results, the die roller, and roll tracking.DieRollRoleflags enum and theTermResult.Rolesproperty.DiceResultbreakdown helpers (KeptResults,DroppedResults,ExplodedResults,RerolledResults) and aVerboseDisplayTextproperty that annotates each die roll with its role.RandomDieRollerandMathNetDieRollernow accept a seed, implement the newIReplayableDieRollerinterface, and expose aReplayTokenthat captures the algorithm and seed for reproducing a roll sequence.DieRollerFactorywithCreateSeededandCreateFromReplayTokenmethods, plusUseSeededDieRoller,UseSeededMathNetDieRoller, andUseReplayDieRolleroptions onDiceNotationOptionsBuilder. Cryptographic rollers are intentionally excluded because their generators are not seedable.