Repository navigation
Conversation
NUMPY_TIME_UNITS gains "generic", NumPy's unit-less unit, which NumPy parses in brackets (<M8[generic]) though its own dtype.str omits it, so the v2 reader accepts the bracketed generic spellings zarr-python writes (<M8[generic], <m8[2generic]). The v3 unit tuple already carried generic and now reuses the shared tuple unchanged. A unit is still required: the unitless <M8 stays refused, as the v2 spec demands. Refs zarr-developers#4580 Assisted-by: ClaudeCode:claude-fable-5
Assisted-by: ClaudeCode:claude-fable-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Accepted the generic time unit in Zarr format 2 time dtypes:
NUMPY_TIME_UNITSgains"generic", NumPy's unit-less unit, which NumPy parses in brackets (<M8[generic]) though its owndtype.stromits it, so the v2 reader accepts the bracketed generic spellings zarr-python writes —<M8[generic], and the scaled form<m8[2generic]. A unit is still required: the unitless<M8stays refused, as the v2 spec demands.The v3 unit tuple (
NUMPY_TIME_UNIT) appended"generic"to the shared tuple and now reuses it unchanged, so v3 behavior is identical. The canonical spelling preservesgenericas written, like every unit other than theμsalias.This is the zarr-metadata half of zarr-developers#4580; the zarr-python half (writing the bracketed form instead of the unitless typestr) is #421. Closing the seam for zarr-python's document model requires a zarr-metadata release carrying this change.
🤖 Generated with Claude Code