Repository navigation
Conversation
…ule removal Rename the changelog fragment from the issue number (4029) to the PR number (4505), as changes/README.md requires, and shorten it to the user-visible effect. Add a removal fragment for the dropped `zarr.storage.default_compressor` deprecation warning, as the deprecation policy in docs/contributing.md requires when a deprecated API is finally removed. Replace the comment block in test_storage_module_is_picklable with a docstring, matching the neighboring tests. Assisted-by: ClaudeCode:claude-fable-5-1 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The test only checked that `zarr.storage` is a plain `ModuleType` and that cloudpickle can pickle a plain module. The first guards against re-adding a one-off `__class__` swap; the second tests cloudpickle. Neither justified a new pinned test dependency, so the test, the `cloudpickle` pin in the `test` group, and its `uv.lock` entries go. Assisted-by: ClaudeCode:claude-opus-5-5
d-v-b
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
The
zarr.storagemodule can now be serialized withcloudpickle. Settingzarr.storage.default_compressorno longer emits a deprecation warning; configurearray.v2_default_compressorthroughzarr.configinstead.This PR cleans up loose ends from zarr-developers#4505 (the VerboseModule removal, closing zarr-developers#4029):
test_storage_module_is_picklable, along with thecloudpicklepin it added to thetestdependency group and the matchinguv.lockentries. The test checked thatzarr.storageis a plainModuleType, which only guards against someone re-adding the one-off__class__swap, and thatcloudpicklecan pickle a plain module, which iscloudpickle's own behavior. Neither justifies a new pinned test dependency.cloudpicklewas not previously inuv.lock, so this is a new dependency rather than an existing indirect one.changes/4029.bugfix.mdtochanges/4505.bugfix.md.changes/README.mdsays the fragment prefix is the pull request number, and towncrier links the entry topull/<number>.changes/4505.removal.md. The deprecation policy indocs/contributing.mdasks for aremovalfragment when a deprecated API is finally removed.After this PR, the change relative to
mainis theVerboseModuledeletion, the removal of the old deprecation-warning test intests/test_v2.py, and the two fragments.pyproject.toml,uv.lock, andtests/test_store/test_core.pymatchmain. Ruff, the pre-commit hooks,uv lock --check, andtests/test_store/test_core.pyplustests/test_v2.pypass locally.Stack bookkeeping
The base branch
fix/4029-pickle-storage-moduleon this fork mirrors the head of zarr-developers#4505 at commit 8bc1b29. Upstream has since mergedmaininto 4505 again (head 9e09101); that merge brings only unrelated dependency and CI updates and does not affect this diff. Retarget this PR tomainonce 4505 merges upstream, or cherry-pick the two commits onto the 4505 branch.🤖 Generated with Claude Code