Skip to content

Eliminate N+1 queries during search index initialization #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
d-oit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Eliminate N+1 queries during search index initialization #368

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a01fb0
perf(search): eliminate N+1 queries during index initialization
google-labs-jules[bot] Jul 1, 2026
9c18602
perf(search): eliminate N+1 queries during index initialization
google-labs-jules[bot] Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/search/progressive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ export const initSearch = async () => {
let totalEntitiesIndexed = 0;
let hasMore = true;
let fetchOffset = 0;
const entityNames = new Map<string, string>();

while (hasMore) {
const chunk = await repository.getAllEntities({ limit: CHUNK_SIZE, offset: fetchOffset });
Expand All @@ -94,6 +95,7 @@ export const initSearch = async () => {
const originalIds: string[] = [];

for (const entity of chunk) {
entityNames.set(entity.id!, entity.name);

@deepsource-io deepsource-io Bot Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forbidden non-null assertion


Using non-null assertions cancels out the benefits of strict null-checking, and introduces the possibility of runtime errors. Avoid non-null assertions unless absolutely necessary. If you still need to use one, write a skipcq comment to explain why it is safe.

docs.push(buildEntityDoc(entity));
originalIds.push(entity.id!);

@deepsource-io deepsource-io Bot Jul 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forbidden non-null assertion


Using non-null assertions cancels out the benefits of strict null-checking, and introduces the possibility of runtime errors. Avoid non-null assertions unless absolutely necessary. If you still need to use one, write a skipcq comment to explain why it is safe.


Expand Down Expand Up @@ -126,7 +128,7 @@ export const initSearch = async () => {
for (const note of allNotes) {
if (note.content && note.content.trim().length > 0) {
const entityName = note.entity_id
? (await repository.getEntityById(note.entity_id))?.name
? entityNames.get(note.entity_id)
: undefined;
noteDocs.push(buildNoteDoc(note, entityName));
noteIds.push(note.id);
Expand Down
Loading