Batched gpr sampling - updated#6
Open
StuartBenjamin wants to merge 11 commits into
Open
Conversation
…filePerturber (these are just 'precompute_factor' split into two separate steps)
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR increases efficiency when sampling random profiles repeatedly (during the pressure-match step for example) by calling numpy.linalg.eigh only once for each profile; this differs from generate_profiles, where numpy.linalg.eigh is computed at each call.
The speedup impacts the total generate_bouquet wall time only if a large number of samples are required, or the resolution of the input kinetic profiles is high.
This pull request includes updates to the test suite (now using batched GPR sampling), as well as a speed test of the batched sampling.
This PR builds on #5, and should be adopted after #5.