twistmarks for start- and endtwists with colorcode element#286
Open
MAETempels wants to merge 17 commits into
Open
twistmarks for start- and endtwists with colorcode element#286MAETempels wants to merge 17 commits into
MAETempels wants to merge 17 commits into
Conversation
- bigger viewbox and container for threadSvg
jo-pol
reviewed
Jul 4, 2026
| southEast = ((displayStitch.substring(displayStitch.lastIndexOf("C")+1)).replaceAll("L","")).length.toString(); | ||
| southWest = ((displayStitch.substring(displayStitch.lastIndexOf("C")+1)).replaceAll("R","")).length.toString(); | ||
| northEast = ((displayStitch.substring(0, displayStitch.indexOf("C"))).replaceAll("L","")).length.toString(); | ||
| northWest = ((displayStitch.substring(0, displayStitch.indexOf("C"))).replaceAll("R","")).length.toString(); |
Collaborator
There was a problem hiding this comment.
Why toString in these expressions? You are treating them as integers below.
Collaborator
Author
There was a problem hiding this comment.
Because I added to min(...) later ...
The template-$ does not have to be a string.
Corrected.
| if (southEast > 5) {southEast = 5} | ||
| if (southWest > 5) {southWest = 5} | ||
| if (northEast > 5) {northEast = 5} | ||
| if (northWest > 5) {northWest = 5} |
Collaborator
There was a problem hiding this comment.
Do you now of Math.min(5,X)?
| } | ||
|
|
||
| // copied from GF_stitches.setcolorcode() | ||
| colorCodeSvg = document.createElement("colorCodeSvg"); |
Collaborator
There was a problem hiding this comment.
This is not a valid HTML tag
| ${twistMarkerDash("twist-2",`${t2}` )} | ||
| ${twistMarkerDash("twist-3",`${t3}` )} | ||
| ${twistMarkerDash("twist-4",`${t4}` )} | ||
| ${twistMarkerDash("twist-5",`${t5}` )} |
Collaborator
There was a problem hiding this comment.
Why a formatted string and not just t1 etc?
Collaborator
Author
There was a problem hiding this comment.
Beginnersmistake.
Corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #285 .
Description / purpose of the changes
The standard colorcode-element is defined as stitches starting and ending with "C".
The randomlist generates stitches that can start and end with twists.
For clearity, we have added these twistmarks to the colorcode-element.
Notify
@d-bl/gf