Skip to content

[#250] Log repo name and record id upon json-ld parsing exception #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkdash wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[#250] Log repo name and record id upon json-ld parsing exception #251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions dspback/utils/jsonld/scraper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import aiohttp
import html
import json

import aiohttp
from bs4 import BeautifulSoup

from dspback.pydantic_schemas import RepositoryType
Expand Down Expand Up @@ -34,7 +33,11 @@ async def retrieve_discovery_jsonld(identifier, repository_type, url):
script_match = (
{"id": "schemaorg"} if repository_type == RepositoryType.HYDROSHARE else {"type": "application/ld+json"}
)
resource_json_ld = scrape_jsonld(resource_data, script_match=script_match)
try:
resource_json_ld = scrape_jsonld(resource_data, script_match=script_match)
except Exception as e:
logging.error(f"Error scraping JSON-LD for record in {repository_type} with identifier {identifier}: {str(e)}")
raise e
if not resource_json_ld:
return None
if repository_type == RepositoryType.HYDROSHARE and resource_json_ld["creativeWorkStatus"] == "Private":
Expand Down