Conversation
The bind handler stored each session's context in pendingSessionContexts right after authentication, before the per-account connection-limit check. When that check rejected a bind, sessionCreated was never invoked, so the entry was never removed and the map grew unbounded. Defer the insert until after all rejection checks pass, and also remove the entry in sessionDestroyed so every teardown path cleans up. Signed-off-by: jchrist <jchrist@cytech.gr>
lykakis
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bind handler stored each session's context in pendingSessionContexts right after authentication, before the per-account connection-limit check. When that check rejected a bind, sessionCreated was never invoked, so the entry was never removed and the map grew unbounded.
Defer the insert until after all rejection checks pass, and also remove the entry in sessionDestroyed so every teardown path cleans up.