fix(deps): pin @deck.gl-community to ~9.3.7 so the deck.gl stack cannot split across minors - #221
Merged
Merged
Conversation
…ot split across minors
|
🎉 This PR is included in version 6.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@deck.gl-community/{layers,editable-layers}were on caret ranges (^9.3.7) while every other deck pin in this repo is a tilde (~9.3.4). The caret range let a fresh lockfile resolution float community to 9.4.x, which requires@deck.gl/core ~9.4.0— incompatible with this package's~9.3.4pin.@cytario/web/node_modules/*9.3.11,@hms-dbmi/viv/node_modules/*9.3.11). The Vite build then bundles mixed 9.3/9.4 deck+luma instances, and the shader hook declarations (DECKGL_FILTER_GL_POSITION,DECKGL_FILTER_COLOR) are injected by one copy while the layer runtime comes from another — so the hooks never get declared and every viewer shader fails to compile:Change
package.json:^9.3.7→~9.3.7for both@deck.gl-community/*entries — matches the tilde style of the@deck.gl/*pins.package-lock.jsonregenerated: community stays at 9.3.8, deck core 9.3.10, and the tree resolves to exactly one@deck.gl/corecopy.Validation
npm ls @deck.gl/coresingle copy; full unit suite passes underTZ=Europe/Berlin(2002 tests; the one local failure without the TZ env is a pre-existing timezone-sensitive date-format test, unrelated to this change).