Skip to content

fix(deps): pin @deck.gl-community to ~9.3.7 so the deck.gl stack cannot split across minors - #221

Merged
dfrkp merged 1 commit into
mainfrom
fix/deckgl-community-tilde-pin
Sep 8, 2026
Merged

fix(deps): pin @deck.gl-community to ~9.3.7 so the deck.gl stack cannot split across minors#221
dfrkp merged 1 commit into
mainfrom
fix/deckgl-community-tilde-pin

Conversation

@dfrkp

@dfrkp dfrkp commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • @deck.gl-community/{layers,editable-layers} were on caret ranges (^9.3.7) while every other deck pin in this repo is a tilde (~9.3.4). The caret range let a fresh lockfile resolution float community to 9.4.x, which requires @deck.gl/core ~9.4.0 — incompatible with this package's ~9.3.4 pin.
  • When that happened downstream (e.g. cytario-ee commit b27ceb3, whose lock regeneration pulled community 9.4.1), npm fragmented the tree into three concurrent copies of the deck.gl/luma stack (root 9.4.0, @cytario/web/node_modules/* 9.3.11, @hms-dbmi/viv/node_modules/* 9.3.11). The Vite build then bundles mixed 9.3/9.4 deck+luma instances, and the shader hook declarations (DECKGL_FILTER_GL_POSITION, DECKGL_FILTER_COLOR) are injected by one copy while the layer runtime comes from another — so the hooks never get declared and every viewer shader fails to compile:
    ERROR: 'DECKGL_FILTER_GL_POSITION' : no matching overloaded function found
    ERROR: 'DECKGL_FILTER_COLOR' : no matching overloaded function found
    luma.gl: Link error ... Vertex shader is not compiled.
    
    This is the ee e2e "viewing issue" (connections-grid thumbnails never render; the compile-error dialog overlays the UI).

Change

  • package.json: ^9.3.7~9.3.7 for both @deck.gl-community/* entries — matches the tilde style of the @deck.gl/* pins.
  • package-lock.json regenerated: community stays at 9.3.8, deck core 9.3.10, and the tree resolves to exactly one @deck.gl/core copy.

Validation

  • Lock diff is 2 lines; npm ls @deck.gl/core single copy; full unit suite passes under TZ=Europe/Berlin (2002 tests; the one local failure without the TZ env is a pre-existing timezone-sensitive date-format test, unrelated to this change).

@dfrkp
dfrkp requested a review from a team as a code owner September 8, 2026 11:15
@dfrkp
dfrkp merged commit dab6a54 into main Sep 8, 2026
7 checks passed
@dfrkp
dfrkp deleted the fix/deckgl-community-tilde-pin branch September 8, 2026 11:19
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 6.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant