fix: close scenario quality security and validation gaps - #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the four gaps found when reviewing
develop@efef55eagainst the scenario-design-quality change:Adds regression tests and updates the per-AC local acceptance mapping, role instructions, Spec and Plan. Corrects the earlier overly broad engineering-completion claim; Phase 5 real-model planning/Reviewer comparisons remain not_run/blocked.
Validation
Using existing Docker quality image
luowang:0.3.1-quality-candidate(11c930d63cb2) with current source/tests/resources/docs/package/workflow mounted read-only. Its lockfile SHA-256 matches the current repository (46406eef352d638790d8537d4c3cd72fe58acf108be6800326266903b2c71281).Fresh quality-image build was blocked by npm mirror ECONNRESET; reused-image validation is not claimed as a new-image build proof. No real model calls, external website writes, deployment, release or history rewriting.
Local command evidence:
.cynos/acceptance/sdq-review/fix-quality.log,fix-final.log,fix-acceptance.log(not committed).