Handle ellmer >= 0.4.2 deprecation of type_object(.additional_properties) - #665
Open
thisisnic wants to merge 4 commits into
Open
Handle ellmer >= 0.4.2 deprecation of type_object(.additional_properties)#665thisisnic wants to merge 4 commits into
type_object(.additional_properties)#665thisisnic wants to merge 4 commits into
Conversation
Contributor
Formatting suggestions availableA patch file with formatting suggestions has been generated. You can apply it using one of these methods: Method 1: Apply via gh CLI# Download and apply the patch directly
gh run download 29255951386 --repo cynkra/constructive --name changes-patch && patch -p1 < changes.patch && rm changes.patchRepo owners can also apply the patch automatically. Click the button to jump to the comment box, then post: Method 2: View the patchClick to see the patch contentsdiff --git a/DESCRIPTION b/DESCRIPTION
index 01e01a2..cd771d1 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -59,4 +59,4 @@ Config/Needs/website: cynkra/cynkratemplate
Config/testthat/edition: 3
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.3.3.9000
+Config/roxygen2/version: 8.0.0.9000
diff --git a/NAMESPACE b/NAMESPACE
index 196dde1..1411ee7 100644
--- a/NAMESPACE
+++ b/NAMESPACE
@@ -554,9 +554,19 @@ export(opts_yearqtr)
export(opts_zoo)
export(opts_zooreg)
import(rlang)
-importFrom(grDevices,dev.off)
-importFrom(grDevices,pdf)
+importFrom(grDevices,
+ dev.off,
+ pdf
+)
importFrom(methods,getSlots)
importFrom(stats,setNames)
+importFrom(utils,
+ capture.output,
+ getFromNamespace,
+ head,
+ methods,
+ packageDescription,
+ tail
+)
useDynLib("")
useDynLib(constructive)This comment was automatically generated by the commit-suggester workflow. |
Contributor
|
Thanks, Nic. This drops an entire test. Intended? |
Author
|
Hmm, looking at it again, I think I dropped it as it looked the same as the one above but with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664
ellmer 0.4.2 deprecates the
.additional_propertiesargument totype_object(). This PR updates thetype_objectconstructor to only include.additional_propertieson older ellmer versions, and version-gates the corresponding tests.