Skip to content
This repository was archived by the owner on Dec 19, 2020. It is now read-only.

Save images by buttons in pages and prepare for video - #44

Open
MicrowaveDev wants to merge 15 commits into
developfrom
save-images
Open

Save images by buttons in pages and prepare for video#44
MicrowaveDev wants to merge 15 commits into
developfrom
save-images

Conversation

@MicrowaveDev

@MicrowaveDev MicrowaveDev commented Jun 24, 2019

Copy link
Copy Markdown
Contributor

@MicrowaveDev MicrowaveDev changed the title Save images Save images and prepare for video Jun 24, 2019
@MicrowaveDev MicrowaveDev changed the title Save images and prepare for video Save images by buttons in pages and prepare for video Jun 24, 2019
@MicrowaveDev MicrowaveDev changed the title Save images by buttons in pages and prepare for video Save images by buttons in pages and prepare for video and fixes Jun 24, 2019
@mastercyb

Copy link
Copy Markdown
Member

Need to verify either this picture has been saved before or not, and if the picture is already in the index the rank and hash must be shown. Also, makeup is needed before merging into master. Is not a current priority. Scheduled to next release

@mastercyb
mastercyb removed the request for review from npopeka June 25, 2019 08:16
@MicrowaveDev

Copy link
Copy Markdown
Contributor Author

#53
#54

@mastercyb mastercyb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, split unrelated bug fixes and declared by pl feature

@MicrowaveDev

Copy link
Copy Markdown
Contributor Author

@xhipster Done. All unrelated fixes has been deleted from PR
#57

@mastercyb

Copy link
Copy Markdown
Member

Cool. I am going to test this feature next week to see if it is viable to include it into Barcelona release.

@mastercyb
mastercyb requested review from mastercyb and npopeka July 12, 2019 18:33
@MicrowaveDev

Copy link
Copy Markdown
Contributor Author

@xhipster need to merge branch with fixes first for fully testing this branch. I will make this PR today

@MicrowaveDev

Copy link
Copy Markdown
Contributor Author

@xhipster This one is PR with fixes: #59

@MicrowaveDev MicrowaveDev changed the title Save images by buttons in pages and prepare for video and fixes Save images by buttons in pages and prepare for video Jul 13, 2019
@cyborgshead cyborgshead mentioned this pull request Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants