Add "source" as a filterable field in the annotations Filters panel - #10960
Open
VidipKhattar wants to merge 7 commits into
Open
Add "source" as a filterable field in the annotations Filters panel#10960VidipKhattar wants to merge 7 commits into
VidipKhattar wants to merge 7 commits into
Conversation
6 tasks
Member
|
@klakhov Please, review the pull request |
klakhov
reviewed
Jul 31, 2026
klakhov
left a comment
Contributor
There was a problem hiding this comment.
Overall pr looks good. Just one small comment
The sources?: Source[] option on Session.annotations.clear leaked in from the delete-by-source branch and has no implementation behind it in this change, so remove it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
Every shape/tag/track already carries a
sourcefield (auto, semi-auto,manual, file, consensus), and it's shown next to objects in the UI, but it
was missing from the annotations Filters panel — there was no way to filter
objects by how they were created.
This is the "smaller first step" proposed in #10933: it doesn't touch bulk
deletion yet, but it already lets users select annotations by source and,
combined with the existing "Remove filtered shapes" annotations action,
lets them delete by source today with no other code changes.
Related: #10933
How has this been tested?
Manually in the UI: opened a task with a mix of manually created and
auto-annotated (Nuclio detector) shapes, opened the Filters panel, added a
Sourcecondition (e.g.Source = Auto), and confirmed only matchingobjects were shown/highlighted. Also verified the filter can be combined
with existing fields (label, type, etc.) and cleared normally.
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.