Skip to content

chore(packs): publish reviewer packs from cuioss/plan-marshall@aea95d611910158ebbf247339df7bdf162a8bb16 - #22

Open
cuioss-release-bot[bot] wants to merge 1 commit into
mainfrom
pr-agent-packs/aea95d611910158ebbf247339df7bdf162a8bb16
Open

chore(packs): publish reviewer packs from cuioss/plan-marshall@aea95d611910158ebbf247339df7bdf162a8bb16#22
cuioss-release-bot[bot] wants to merge 1 commit into
mainfrom
pr-agent-packs/aea95d611910158ebbf247339df7bdf162a8bb16

Conversation

@cuioss-release-bot

Copy link
Copy Markdown

Generated artifact set, published from cuioss/plan-marshall@aea95d6. The packs/ directory is REPLACED rather than merged, so a review domain that stopped deriving disappears from the published set. Do not edit these files by hand — they are regenerated from the source marketplace.

@cuioss-release-bot cuioss-release-bot Bot added the skip-bot-review Skip automated bot code review (Gemini/CodeRabbit/Sourcery) label Sep 4, 2026
@cla-assistant

cla-assistant Bot commented Sep 4, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


cui-release-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="packs/docs.md" line_range="6-7" />
<code_context>
+Regenerate with:
+  ./pw generate --target pr-agent --output target/pr-agent
+This artifact carries the docs domain part alone. The review charter lives in the
+spine artifact (spine.md) and appears in no domain artifact, so this file on its
+own carries none of it. Apply the spine artifact alongside this one.
+-->
+
</code_context>
<issue_to_address>
**issue (broader_impact):** Each generated domain pack explicitly omits the review charter and only tells the consumer to apply `spine.md` alongside it. This conflicts with the repository's documented one-pack-per-repository consumption model, so selecting any one of these packs gives the reviewer domain rules without the cross-cutting charter, including its required security, validation, error-handling, and substantiation rules.

**Triggers:** When a repository selects one domain pack as documented rather than composing it with `spine.md`.

**Suggested fix:** Generate each published pack with the spine content included, or change the pack-selection and consumer mechanism so the spine is automatically loaded whenever a domain pack is selected.
</issue_to_address>

Sourcery assessment

Approval pending. 1 finding to address first.

Blocking findings: packs/docs.md:7


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Comment thread packs/docs.md
Comment on lines +6 to +7
spine artifact (spine.md) and appears in no domain artifact, so this file on its
own carries none of it. Apply the spine artifact alongside this one.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (broader_impact): Each generated domain pack explicitly omits the review charter and only tells the consumer to apply spine.md alongside it. This conflicts with the repository's documented one-pack-per-repository consumption model, so selecting any one of these packs gives the reviewer domain rules without the cross-cutting charter, including its required security, validation, error-handling, and substantiation rules.

Triggers: When a repository selects one domain pack as documented rather than composing it with spine.md.

Suggested fix: Generate each published pack with the spine content included, or change the pack-selection and consumer mechanism so the spine is automatically loaded whenever a domain pack is selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-bot-review Skip automated bot code review (Gemini/CodeRabbit/Sourcery)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants