chore(packs): publish reviewer packs from cuioss/plan-marshall@aea95d611910158ebbf247339df7bdf162a8bb16 - #22
Conversation
|
cui-release-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="packs/docs.md" line_range="6-7" />
<code_context>
+Regenerate with:
+ ./pw generate --target pr-agent --output target/pr-agent
+This artifact carries the docs domain part alone. The review charter lives in the
+spine artifact (spine.md) and appears in no domain artifact, so this file on its
+own carries none of it. Apply the spine artifact alongside this one.
+-->
+
</code_context>
<issue_to_address>
**issue (broader_impact):** Each generated domain pack explicitly omits the review charter and only tells the consumer to apply `spine.md` alongside it. This conflicts with the repository's documented one-pack-per-repository consumption model, so selecting any one of these packs gives the reviewer domain rules without the cross-cutting charter, including its required security, validation, error-handling, and substantiation rules.
**Triggers:** When a repository selects one domain pack as documented rather than composing it with `spine.md`.
**Suggested fix:** Generate each published pack with the spine content included, or change the pack-selection and consumer mechanism so the spine is automatically loaded whenever a domain pack is selected.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: packs/docs.md:7
| spine artifact (spine.md) and appears in no domain artifact, so this file on its | ||
| own carries none of it. Apply the spine artifact alongside this one. |
There was a problem hiding this comment.
issue (broader_impact): Each generated domain pack explicitly omits the review charter and only tells the consumer to apply spine.md alongside it. This conflicts with the repository's documented one-pack-per-repository consumption model, so selecting any one of these packs gives the reviewer domain rules without the cross-cutting charter, including its required security, validation, error-handling, and substantiation rules.
Triggers: When a repository selects one domain pack as documented rather than composing it with spine.md.
Suggested fix: Generate each published pack with the spine content included, or change the pack-selection and consumer mechanism so the spine is automatically loaded whenever a domain pack is selected.
Generated artifact set, published from cuioss/plan-marshall@aea95d6. The packs/ directory is REPLACED rather than merged, so a review domain that stopped deriving disappears from the published set. Do not edit these files by hand — they are regenerated from the source marketplace.