chore(packs): publish reviewer packs from cuioss/plan-marshall@ef4bf54b5da0927b8f0997bbf2bc55448d0cea5e - #21
Conversation
|
cui-release-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="packs/docs.md" line_range="5-7" />
<code_context>
+Derived from the cuioss/plan-marshall marketplace (marketplace/bundles/**).
+Regenerate with:
+ ./pw generate --target pr-agent --output target/pr-agent
+This artifact carries the docs domain part alone. The review charter lives in the
+spine artifact (spine.md) and appears in no domain artifact, so this file on its
+own carries none of it. Apply the spine artifact alongside this one.
+-->
+
</code_context>
<issue_to_address>
**issue (bug_risk):** The generated Markdown artifacts are not consumed by the configured reviewer: PR-Agent loads `.pr_agent.toml`, while this change adds only unreferenced files under `packs/` and does not update `extra_instructions` or add a loader. Consequently, the domain rules and the spine text never reach the review prompt, so publishing these packs has no effect on reviews.
**Triggers:** On reviews using this repository's current PR-Agent configuration.
**Suggested fix:** Generate or install the pack into `.pr_agent.toml` as `[pr_reviewer].extra_instructions`, or add and configure an explicit loader that composes `spine.md` with the selected domain artifact before invoking PR-Agent.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: packs/docs.md:7
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| This artifact carries the docs domain part alone. The review charter lives in the | ||
| spine artifact (spine.md) and appears in no domain artifact, so this file on its | ||
| own carries none of it. Apply the spine artifact alongside this one. |
There was a problem hiding this comment.
issue (bug_risk): The generated Markdown artifacts are not consumed by the configured reviewer: PR-Agent loads .pr_agent.toml, while this change adds only unreferenced files under packs/ and does not update extra_instructions or add a loader. Consequently, the domain rules and the spine text never reach the review prompt, so publishing these packs has no effect on reviews.
Triggers: On reviews using this repository's current PR-Agent configuration.
Suggested fix: Generate or install the pack into .pr_agent.toml as [pr_reviewer].extra_instructions, or add and configure an explicit loader that composes spine.md with the selected domain artifact before invoking PR-Agent.
Generated artifact set, published from cuioss/plan-marshall@ef4bf54. The packs/ directory is REPLACED rather than merged, so a review domain that stopped deriving disappears from the published set. Do not edit these files by hand — they are regenerated from the source marketplace.