chore: declare the pre-commit profile as source-mutating - #228
Merged
Merged
Conversation
-Ppre-commit rewrites tracked sources in place (license:format and rewrite:run, both bound ahead of verify), so a quality-gate that resolves it is a mutating command. Nothing declared that, which left plan-marshall treating the gate as safe to run against a dirty worktree. build.maven.profiles.mutating is the authored opt-in key; the value is a CSV of profile ids, symmetric with the existing build.maven.profiles.skip and build.maven.profiles.map.canonical. There is no pattern inference -- operator authoring is the only source, and absence means 'unknown', not 'safe'. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: cuioss/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Ppre-commitrewrites tracked sources in place —license:formatandrewrite:run, both bound ahead ofverify— so a canonicalquality-gatethat resolves it is a mutating command. Nothing declared that, which left plan-marshall treating the gate as safe to run against a dirty worktree.build.maven.profiles.mutatingis the authored opt-in key (_maven_cmd_discover.py,EXT_KEY_PROFILES_MUTATING). The value is a CSV of profile ids, symmetric with the existingbuild.maven.profiles.skipandbuild.maven.profiles.map.canonical. There is no pattern inference — operator authoring is the only source, and absence of the field means unknown, not safe.This is a declaration only: it changes no build behaviour in this repo.
-Ppre-commitdid and still does auto-fix, which is the intended org-wide norm — the gate auto-fixes in every language; review what it changed and commit it.Sequencing note: the resolved-command contract in plan-marshall (
manage-architecture/standards/resolve-command.md) currently says a gate context "MUST NOT run amutating: truecommand as the pre-push worktree gate without operator confirmation". That clause is being removed in parallel — auto-fix is intended normal behaviour and should not prompt. If this lands first, a pre-push run may prompt once until that change is in.🤖 Generated with Claude Code