chore(deps): drop the okhttp-tls pin its owner already supplies - #219
Conversation
Part of an org-wide dependency-version centralization pass. cui-http-core pinned com.squareup.okhttp3:okhttp-tls at a literal 5.5.0, under a comment admitting what it was: "Version aligned with the transitive okhttp brought in by cui-test-mockwebserver-junit5." A hand-maintained copy of another artifact's version, kept in step by hand. cui-test-mockwebserver-junit5 declares okhttp-tls at compile scope and owns version.okhttp3 deliberately - that repo exists to wrap okhttp, so its cadence must not be coupled to the parent release train. The right fix is therefore NOT to move okhttp into the parent, but to delete this declaration and let the artifact arrive from the owner it was already being aligned to. Verified with dependency:list -DincludeScope=test: com.squareup.okhttp3:okhttp-tls:jar:5.5.0:test is still present, at the same version and scope, now transitively. The listing is set-identical before and after - only its position in the list moves, from direct to transitive. Also drops version.jmh 1.37 from cui-http-benchmarking: cui-java-bom now manages jmh-core and the annotation processor at that value. The module keeps its own dependency declarations, so jmh-core stays at compile scope, which the harness needs - its benchmarks live in src/main/java. Verified: clean install BUILD SUCCESS. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FS7nXoXh43D2EzEAkn3APT
There was a problem hiding this comment.
Sorry @cuioss-oliver, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 1 minute by commenting @sourcery-ai review. Upgrade to get a review now.
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: cuioss/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Part of an org-wide dependency-version centralization pass across the 18 cuioss repos.
The okhttp-tls pin
cui-http-corepinnedcom.squareup.okhttp3:okhttp-tlsat a literal5.5.0, under a commentadmitting what it was:
A hand-maintained copy of another artifact's version, kept in step by hand.
The fix is not to centralize okhttp.
cui-test-mockwebserver-junit5ownsversion.okhttp3deliberately — that repo exists to wrap okhttp, so its cadence must not be coupled to the parent
release train. Copying okhttp into the parent would be exactly the mistake this track avoids. The
right move is to delete this declaration and let the artifact arrive from the owner it was already
being aligned to.
Verified with
dependency:list -DincludeScope=test:com.squareup.okhttp3:okhttp-tls:jar:5.5.0:testis still present, same version, same scope, nowtransitively. The listing is set-identical before and after — only its position moves, from direct to
transitive.
JMH
Drops
version.jmh1.37fromcui-http-benchmarking;cui-java-bomnow managesjmh-coreandthe annotation processor at that value, without a scope.
That last detail matters and this repo is why. Managing JMH at
<scope>test</scope>— ascui-parent-pom1.7.1 briefly did — silently rewrote this module's compile-scopedjmh-coretotest, becausedependencyManagementsupplies every field a declaration omits, not only theversion. That is what broke #218 with
package org.openjdk.jmh.annotations does not exist.cui-parent-pom1.7.2 fixes it, and this PR targets 1.7.2.clean installBUILD SUCCESS.🤖 Generated with Claude Code
https://claude.ai/code/session_01FS7nXoXh43D2EzEAkn3APT