Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cubejs-backend-native/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"dependencies": {
"@cubejs-backend/cubesql": "1.7.21",
"@cubejs-backend/shared": "1.7.21",
"@cubejs-infra/post-installer": "^0.0.7"
"@cubejs-infra/post-installer": "^0.1.2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The declared range here is ^0.1.2, but the PR title and branch both say 0.2.0. Worth reconciling one or the other before merge — if a 0.2.0 of post-installer is what you actually intend to ship against, this line (and the lockfile) still point at the 0.1.x line.

Separate, minor note on the range semantics: ^0.0.7 was effectively an exact pin (npm's caret on 0.0.x allows nothing else), whereas ^0.1.2 resolves to >=0.1.2 <0.2.0. So downstream consumers installing @cubejs-backend/native fresh (no lockfile) will now float across future 0.1.x patch releases of a package whose whole job is to run a postinstall script that downloads and unpacks a binary. That's a deliberate and reasonable trade — it's exactly what lets shared float off decompress — but if you want to keep the install-time surface pinned, ~0.1.2 or an exact 0.1.2 gets the same security win without the float.

},
"resources": {
"vars": {
Expand Down
Loading
Loading