Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The declared range here is
^0.1.2, but the PR title and branch both say0.2.0. Worth reconciling one or the other before merge — if a0.2.0of post-installer is what you actually intend to ship against, this line (and the lockfile) still point at the0.1.xline.Separate, minor note on the range semantics:
^0.0.7was effectively an exact pin (npm's caret on0.0.xallows nothing else), whereas^0.1.2resolves to>=0.1.2 <0.2.0. So downstream consumers installing@cubejs-backend/nativefresh (no lockfile) will now float across future0.1.xpatch releases of a package whose whole job is to run apostinstallscript that downloads and unpacks a binary. That's a deliberate and reasonable trade — it's exactly what letssharedfloat offdecompress— but if you want to keep the install-time surface pinned,~0.1.2or an exact0.1.2gets the same security win without the float.