docs: document country name matching in region maps - #11421
Conversation
|
Claude finished @igorlukanin's task in 1m 38s —— View job Review complete — docs-only change, no blockers. 3 findings: 2 medium, 1 low (all inline).Full review
ScopeProse-only addition of one H3 section to an existing page in What's good
Findings
Details and suggested edits are in the inline comments. Minor notes (not worth inline threads)
What I could not verifyThe behavior being documented lives in the frontend/chart implementation, which isn't in this repo — I did not run the Mintlify dev server or a linter — this is a prose-only |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @igorlukanin's task in 46s —— View job Re-review after
|
| # | Prior issue | Status |
|---|---|---|
| 1 | Para 1 vs para 2 contradiction on US |
✅ Fixed — US dropped from the interchangeable list at map.mdx:74; para 2 (map.mdx:76) now introduces it as "Bare 2-letter codes such as US…". The two paragraphs no longer disagree. |
| 2 | H3 inserted above the choropleth-gradient paragraph | ✅ Fixed — the palette sentence is back in the Region map H2 intro at map.mdx:70, with ### Country name matching starting at map.mdx:72. |
| 3 | colouring British spelling |
✅ Fixed — now coloring at map.mdx:76. |
Bonus: the Alpha-3 gap I flagged as an aside is closed too — map.mdx:62 now lists ISO3166-1-Alpha-3 alongside ISO3166-1-Alpha-2, so the Property list and the "2- and 3-letter ISO code properties" claim at map.mdx:74 line up. The author confirmed the World countries source exposes both.
Thread housekeeping
All three of my threads were already resolved (GitHub marked them outdated once the lines moved) — nothing left to resolve, and no duplicate inline comments to skip.
New issues
None. The rewrite is a clean subtraction plus a move — no new claims were introduced, and the sentence flow reads correctly with US deferred to the second paragraph. Section structure is now: H2 intro (requirements list → allowed-properties note → auto-pick → palette) → ### Country name matching → ### Custom GeoJSON, which is consistent with how Point map is broken up earlier on the page.
Standing caveat (unchanged)
The matching behavior itself lives outside this repo, so I still can't verify the claims against the implementation — reverse matching (name in data, code as Property) in particular. The author's confirmation on Alpha-3 covers the one piece I could point at concretely. This is a prose-only .mdx change with no components, links, or frontmatter touched, so the code-review axes in the review config (security, performance, error handling, test coverage) don't apply; the Mintlify preview build is the relevant check and it's green.
• Branch •
c16cc12 to
68c22f2
Compare
|
Claude finished @igorlukanin's task in 48s —— View job Re-review after force-push (
|
| # | Prior issue | Status |
|---|---|---|
| 1 | Para 1 vs para 2 contradiction on US |
✅ US is absent from the interchangeable list at map.mdx:74 and introduced at map.mdx:76 as "Bare 2-letter codes such as US…" |
| 2 | H3 inserted above the choropleth-gradient paragraph | ✅ Palette sentence sits in the Region map H2 intro at map.mdx:70; ### Country name matching starts at map.mdx:72 |
| 3 | colouring British spelling |
✅ coloring at map.mdx:76 |
| — | Alpha-3 gap (aside) | ✅ ISO3166-1-Alpha-3 listed at map.mdx:62, matching the "2- and 3-letter ISO code properties" claim |
Section structure reads: H2 intro (requirements → allowed-properties → auto-pick → palette) → ### Country name matching → ### Custom GeoJSON → ### Unmatched regions, consistent with how Point map is broken up earlier on the page. Conventions check out — correct site (docs-mintlify, not the deprecated /docs), H2/H3 only with no stray H1, bold UI labels matching the rest of the page, no docs.json or frontmatter change needed for a prose-only edit.
Thread housekeeping
All three of my earlier threads are already isResolved: true and outdated — nothing to resolve, and no duplicate inline comments to post or skip.
Minor note (not worth an inline thread)
map.mdx:74 — "The same applies to the 2- and 3-letter ISO code properties" is slightly loose, since codes don't have alternate spellings the way names do; the clause that follows ("it works in either direction") is what actually carries the meaning. Reads fine as is; only worth touching if you're editing the sentence anyway.
Standing caveat (unchanged)
The matching behavior lives outside this repo — rg for ISO3166 / world countries hits only this .mdx — so I can't verify the claims against the implementation, reverse matching (name in data, code as Property) in particular. The author confirmed the World countries source exposes Alpha-3, which covers the one piece I could point at concretely.
The code-review axes in the review config (security, performance, error handling, test coverage) don't apply to a prose-only .mdx change with no components, links, or frontmatter touched. I did not run the Mintlify dev server or a linter — there's nothing for either to catch here beyond what CI runs; the Mintlify preview build is the relevant check.
|
Claude finished @igorlukanin's task in 42s —— View job Re-review after
|
| Location | Before | After |
|---|---|---|
map.mdx:61 |
`World countries`, `US states` |
`World Countries`, `US States` |
map.mdx:74, :78 |
World countries, US states | World Countries, US States |
ISO3166-1-Alpha-3 at map.mdx:62 was already in the tree from 68c22f2; the diff hunk just re-renders that line alongside the Source edit. No prose, structure, or claims changed.
Assessment
Consistent — grep -niE "world countries|us states" over docs-mintlify returns only this file, and every occurrence of the two labels is now title-cased in the same way. Custom was already title-cased, so all three Source options match each other.
map.mdx:9 still reads "countries, US states, or any custom GeoJSON" in lowercase, but that's the intro sentence describing what a region map paints, not a reference to the settings-panel option — leaving it lowercase is correct.
The three prior findings remain fixed (US-code contradiction, H3 placement, colouring → coloring), and section structure is unchanged: H2 intro → ### Country name matching → ### Custom GeoJSON → ### Unmatched regions.
Style note (not worth an inline thread)
map.mdx:61 renders the option labels in backticks (`World Countries`) while :74 and :78 render them in bold (World Countries), and :82 uses bold for Custom too. Bold is what the rest of the page uses for UI controls (Property, Size, Fill unmatched, Default color). Since you're already touching that line for casing, switching it to bold would make the whole page consistent — but this predates the PR and reads fine either way.
Thread housekeeping
All three of my earlier threads are isResolved: true and outdated. Nothing to resolve, no duplicates to skip.
Standing caveat (unchanged)
I can't verify the casing against the actual UI, or the matching behavior against its implementation — both live outside this repo (rg for ISO3166 / World Countries hits only this .mdx). I'm taking the commit message's claim that these match the UI at face value; the check I can make is internal consistency, and that holds. Reverse matching (name in data, code as Property) likewise remains unverifiable from here.
Prose-only .mdx change with no components, links, or frontmatter touched, so the code-review axes in the review config (security, performance, error handling, test coverage) don't apply. The Mintlify preview build is the relevant check; I did not run the dev server or a linter, as there's nothing for either to catch beyond what CI runs.
• Branch •
|
Claude finished @igorlukanin's task in 31s —— View job Re-review after
|
| Location | Before | After |
|---|---|---|
map.mdx:61 |
`World Countries`, `US States`, `Custom` |
World Countries, US States, Custom |
No prose, structure, or claims changed.
Assessment
This closes the last thing I had. The page now uses bold uniformly for settings-panel controls — Source, Property, Dimension, Measure, Size, Color, Default color, Fill unmatched — and the three Source option values render the same way at :61, :74, :78, and :82. Backticks are left for actual data values and property keys (name, ISO3166-1-Alpha-2, United States, DE), which is the right split: bold = thing you click, code = thing you type or that appears in your data.
map.mdx:9 still reads "countries, US states, or any custom GeoJSON" in lowercase plain text, but that's the intro describing what a region map paints, not a reference to the option — correctly left alone.
All three original findings remain fixed:
| # | Prior issue | Status |
|---|---|---|
| 1 | Para 1 vs para 2 contradiction on US |
✅ US absent from the interchangeable list at :74, introduced at :76 as "Bare 2-letter codes such as US…" |
| 2 | H3 inserted above the choropleth-gradient paragraph | ✅ Palette sentence sits in the H2 intro at :70; ### Country name matching starts at :72 |
| 3 | colouring British spelling |
✅ coloring at :76 |
| — | Alpha-3 gap (aside) | ✅ ISO3166-1-Alpha-3 listed at :62 |
| — | Backticks vs bold for Source options (style note) | ✅ Fixed by this commit |
Section structure unchanged: H2 intro (requirements → allowed properties → auto-pick → palette) → ### Country name matching → ### Custom GeoJSON → ### Unmatched regions, mirroring how Point map is broken up earlier on the page. Conventions check out — correct site (docs-mintlify, not the deprecated /docs), H2/H3 only, no docs.json or frontmatter change needed for a prose-only edit.
New issues
None.
Thread housekeeping
All three of my earlier threads are isResolved: true and outdated — nothing to resolve, no duplicates to skip.
Standing caveat (unchanged)
The matching behavior lives outside this repo — rg for ISO3166 / World Countries hits only this .mdx — so I can't verify the claims against the implementation, reverse matching (name in data, code as Property) in particular. I likewise can't check the label casing against the actual UI and am taking the commit message at face value; what I can check is internal consistency, and that holds.
Prose-only .mdx change with no components, links, or frontmatter touched, so the code-review axes in the review config (security, performance, error handling, test coverage) don't apply. I did not run the Mintlify dev server or a linter — there's nothing for either to catch beyond what CI runs; the Mintlify preview build is the relevant check.
a00ba11 to
18b755b
Compare
|
Claude finished @igorlukanin's task in 40s —— View job Re-review after force-push (
|
| Location | Content |
|---|---|
map.mdx:61 |
Source options in bold: World Countries, US States, Custom |
map.mdx:62 |
Property list includes both ISO3166-1-Alpha-2 and ISO3166-1-Alpha-3 |
map.mdx:70 |
Palette/gradient sentence sits in the Region map H2 intro |
map.mdx:72–78 |
### Country name matching — three paragraphs |
All prior findings remain fixed:
| # | Prior issue | Status |
|---|---|---|
| 1 | Para 1 vs para 2 contradiction on US |
✅ US absent from the interchangeable list at :74, introduced at :76 as "Bare 2-letter codes such as US…" |
| 2 | H3 inserted above the choropleth-gradient paragraph | ✅ Palette sentence in the H2 intro at :70; H3 starts at :72 |
| 3 | colouring British spelling |
✅ coloring at :76 |
| — | Alpha-3 gap (aside) | ✅ Listed at :62 |
| — | Backticks vs bold for Source options (style note) | ✅ Bold throughout |
Consistency check still holds: grep -niE "world countries\|us states" over docs-mintlify returns only this file, and every settings-panel reference to the two labels is title-cased and bold. map.mdx:9 stays lowercase plain text, which is correct — it describes what a region map paints, not the option. Bold is used for controls, backticks for data values and property keys.
Conventions: correct site (docs-mintlify, not the deprecated /docs), H2/H3 only with no stray H1, no docs.json or frontmatter change needed for a prose-only edit. Section structure — H2 intro → ### Country name matching → ### Custom GeoJSON → ### Unmatched regions — mirrors how Point map is broken up earlier on the page.
New issues
None.
Thread housekeeping
All three of my earlier threads are isResolved: true and outdated — nothing to resolve, no duplicates to skip.
Standing caveat (unchanged)
The matching behavior lives outside this repo — rg for ISO3166 / World Countries hits only this .mdx — so I can't verify the claims against the implementation, reverse matching (name in data, code as Property) in particular. I likewise can't check the label casing against the actual UI and am taking the commit message at face value; internal consistency is what I can check, and it holds.
Prose-only .mdx change with no components, links, or frontmatter touched, so the code-review axes in the review config (security, performance, error handling, test coverage) don't apply. I did not run the Mintlify dev server or a linter — there's nothing for either to catch beyond what CI runs; the Mintlify preview build is the relevant check.
• Branch •
18b755b to
dc1ebbe
Compare
|
Claude finished @igorlukanin's task in 37s —— View job Re-review after force-push (
|
| Location | Content |
|---|---|
map.mdx:61 |
Source options in bold: World Countries, US States, Custom |
map.mdx:62 |
Property list includes both ISO3166-1-Alpha-2 and ISO3166-1-Alpha-3 |
map.mdx:70 |
Palette/gradient sentence sits in the Region map H2 intro |
map.mdx:72–78 |
### Country name matching — three paragraphs |
All prior findings remain fixed:
| # | Prior issue | Status |
|---|---|---|
| 1 | Para 1 vs para 2 contradiction on US |
✅ US absent from the interchangeable list at :74, introduced at :76 as "Bare 2-letter codes such as US…" |
| 2 | H3 inserted above the choropleth-gradient paragraph | ✅ Palette sentence in the H2 intro at :70; H3 starts at :72 |
| 3 | colouring British spelling |
✅ coloring at :76 |
| — | Alpha-3 gap (aside) | ✅ Listed at :62 |
| — | Backticks vs bold for Source options (style note) | ✅ Bold throughout |
Conventions still check out — correct site (docs-mintlify, not the deprecated /docs), H2/H3 only with no stray H1, bold for settings-panel controls and backticks for data values / property keys, no docs.json or frontmatter change needed for a prose-only edit. Section structure — H2 intro → ### Country name matching → ### Custom GeoJSON → ### Unmatched regions — mirrors how Point map is broken up earlier on the page. map.mdx:9 stays lowercase plain text, correctly, since it describes what a region map paints rather than naming the option.
New issues
None.
Thread housekeeping
All three of my earlier threads are isResolved: true and outdated — nothing to resolve, no duplicates to skip.
Standing caveat (unchanged)
The matching behavior lives outside this repo — rg for ISO3166 / World Countries hits only this .mdx — so I can't verify the claims against the implementation, reverse matching (name in data, code as Property) in particular. I likewise can't check the label casing against the actual UI and am taking the commit message at face value; internal consistency is what I can check, and it holds.
Prose-only .mdx change with no components, links, or frontmatter touched, so the code-review axes in the review config (security, performance, error handling, test coverage) don't apply. I did not run the Mintlify dev server or a linter — there's nothing for either to catch beyond what CI runs; the Mintlify preview build is the relevant check.
1 participant
Summary
Region maps join a query dimension to the boundary data by name or ISO code, and the World Countries boundaries use long-form names — so
United Statesin a user's data did not match theUnited States of Americapolygon. That join is now tolerant of alternate spellings, and this documents the behavior.Added a Country name matching section under Region map covering what resolves (long forms, endonyms, abbreviations, both ISO code properties, in either direction), the two guarantees worth knowing — matching is exact rather than approximate, and bare 2-letter codes only count as country codes when Property is set to an ISO code property — and that this applies to World countries only, not US states or Custom.
Test plan